opral / ninja-i18n-action Goto Github PK

Context

Ninja fails for private repos as Ninja has no rights to clone the branch of a private repo.

Example

https://github.com/NiklasBuchfink/privateExample/actions/runs/8568159584/job/23481437772?pr=1

Proposal

Similar to #3
We need to use the checkout action to directly checkout both branches or better, check out the merge simulation and main.

In our repository, we've implemented a CI workflow for commit message lint that only permits merges if the commit messages follow a specific format.

Currently, the commit messages created by this action adhere to the following example: 'Fink 🐦: update translations.'

Context

https://discord.com/channels/897438559458430986/1255494342509072426/1255520136505458778:

+1 if translation files are being touched, give the option to a success message: "hey, everything is fine here". which gives you the affirmation of "all checks passed". NiklasBuchfink provide this as an option?

Proposal

Option to always get a Ninja comment if translation files have changed

Problem

• You are working on a branch refactor/api that is unrelated to UI translations
• Someone fixed a few lint reports on main
• You get notified that you need to update the translations in refactor/api

Why?
Compared to main, refactor/api now has new lint errors. This could be fixed by merging main into refactor/api, but I don't care about translations because I'm working on something completely different.

Proposal

Ninja needs to check if the branch contains updated translation files. Only if there are changes in this branch it makes sense to create a comment.