With neon, ovos, chatterbox, and mycroft (or holmesV) cores now installable as different packages, resource files have more locations to be bundled. resolve_resource_file currently checks for mycroft defaults.

A few potential solutions come to mind:

• maintain a list of known packages to check in the path
• accept some param in resolve_resource_file to specify a root path (or package name to locate in the path)
• specify that each core extends resolve_resource_file somewhere and import that method (makes modules less universal)
• add some search logic to find arbitrary res directories in some set path(s)

When using the stop command from the CLI it returns an error on 4 different skills.

I'm using the dev version with the latest commit.

Errors from the skills.log:

2021-02-06 02:57:32.214 - OVOS - ovos_utils.waiting_for_mycroft.base_skill:on_error:155 - ERROR - An error occurred while processing a request in Playback Control Skill
Traceback (most recent call last):
  File "/home/mycroft/core/mycroft/skills/mycroft_skill/event_container.py", line 66, in wrapper
    handler(message)
  File "/opt/mycroft-venv/lib/python3.7/site-packages/ovos_utils/waiting_for_mycroft/base_skill.py", line 184, in __handle_stop
    super().__handle_stop()
TypeError: __handle_stop() missing 1 required positional argument: '_'
2021-02-06 02:57:32.247 - OVOS - ovos_utils.waiting_for_mycroft.base_skill:on_error:155 - ERROR - An error occurred while processing a request in Joking Skill
Traceback (most recent call last):
  File "/home/mycroft/core/mycroft/skills/mycroft_skill/event_container.py", line 66, in wrapper
    handler(message)
  File "/opt/mycroft-venv/lib/python3.7/site-packages/ovos_utils/waiting_for_mycroft/base_skill.py", line 184, in __handle_stop
    super().__handle_stop()
TypeError: __handle_stop() missing 1 required positional argument: '_'
2021-02-06 02:57:32.252 - OVOS - ovos_utils.waiting_for_mycroft.base_skill:on_error:155 - ERROR - An error occurred while processing a request in Timer Skill
Traceback (most recent call last):
  File "/home/mycroft/core/mycroft/skills/mycroft_skill/event_container.py", line 66, in wrapper
    handler(message)
  File "/opt/mycroft-venv/lib/python3.7/site-packages/ovos_utils/waiting_for_mycroft/base_skill.py", line 184, in __handle_stop
    super().__handle_stop()
TypeError: __handle_stop() missing 1 required positional argument: '_'
2021-02-06 02:57:32.254 - OVOS - ovos_utils.waiting_for_mycroft.base_skill:on_error:155 - ERROR - An error occurred while processing a request in News Skill
Traceback (most recent call last):
  File "/home/mycroft/core/mycroft/skills/mycroft_skill/event_container.py", line 66, in wrapper
    handler(message)
  File "/opt/mycroft-venv/lib/python3.7/site-packages/ovos_utils/waiting_for_mycroft/base_skill.py", line 184, in __handle_stop
    super().__handle_stop()
TypeError: __handle_stop() missing 1 required positional argument: '_'

since PRs are not merged we can provide some alternative imports adding functionality that mycroft refuses/takes forever implementing

this will only work for skills, not core functionality like intents

• provide a subclass for skill gui, users would need to assign this to self.gui in their initialize method
• provide a subclass for common play skill
  • my alternative skill with all unmerged PRs will replace official skill

Initial improvements to bundle

• MycroftAI/mycroft-core#2698
• MycroftAI/mycroft-core#2660

while discussing #66 the consensus seems to be that we want to use type hints all over the codebase

The test has not been updated and still tries to import detect_lang_google. This broke on the Alpine Linux CI and is currently blocking the package upgrade to 0.0.7.

Currently this uses googletrans, which makes use of Google Translate in the background. This is a proprietary service and, well... ran by Google, which isn't known for it's good privacy.

It would be good to get rid of this dependency in the future in favor of something more privacy friendly, preferable even possible to be self-hosted and FOSS.

Installed the ovos-vlc-plugin for testing the holmesV patch fixing plugin loading in the audio service, I got import errors saying that it can't find phoneme_guesser. should it be moved from install_extras to install_requires?

Or should phoneme_guesser be a requirement for the vlc-plugin?

we could include functionality from https://github.com/jmontane/mycroft-update-translations in this package

this helps both in translating skills, but is also great to quickly create a dataset

Is there any other interest in or reason against adding an optional config parameter being added to the base STT class (like TTS has).

This would diverge from Mycroft but retain compatibility while also allowing a non-Mycroft configuration to be used.