Code Monkey home page Code Monkey logo

skill-ovos-volume's People

Contributors

aiix avatar atd avatar chancencounter avatar denics avatar emphasize avatar jarbasal avatar neondaniel avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

emphasize atd putnik denics

skill-ovos-volume's Issues

allow "louder" intent

single word intent was previously supported with the old intent that overmatched, but since #31 the "volume" keyword is also required

a new intent should be explicitly added for "louder", and in the future should probably require exact matches when that functionality is introduced

issue with volume in italian

In docker, when I try to set the volume in Italian, I get:

  • hey mycroft, imposta il volume a 10 (set volume to 10)
  • Il volume è a 50 (the volume is 50) which is not the answer I am waiting from it. It this is the docker behavior I think it should be documented, but I doubt so, I ALWAYS get 50 as an answer (not even 42)

skill settings

from matrix chat

(edit: replacing screenshot with transcript in case the hosted image ever times out - Chance)

proposed config options:

  • boot_volume -> False/integer if False is disabled, else should be an integer 0 - 100, default False
  • min_boot_volume -> default 20, do not allow volume to go lower than this even if user requested it (so we can be really sure user knows what he is doing)
  • scale1to10 -> true/false , consider the range 0 - 10 (int) 1 corresponds to 10%, mycroft style compat mode, default False
  • scale0to1 -> true/false , consider the range 0 - 1 (float) to be percentages, 0.1 corresponds to 10% , default True
  • scale1to100 -> true/false , consider the range 1 - 100 (int) to be percentages, default True

ovos_workshop.skills.base:_startup:262 - ERROR - Skill initialization failed

It seems that the skill is looking for something into the backend.

2023-04-08 09:46:37.719 - skills - ovos_utils.messagebus:add:606 - DEBUG - Added event: skill-ovos-volume.openvoiceos.set
2023-04-08 09:46:37.726 - skills - ovos_workshop.skills.base:_startup:262 - ERROR - Skill initialization failed
Traceback (most recent call last):
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 252, in _startup
    self._init_settings_manager()
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/mycroft_skill.py", line 90, in _init_settings_manager
    self.settings_manager = SkillSettingsManager(self)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ovos/.venv/lib/python3.11/site-packages/mycroft/skills/settings.py", line 81, in __init__
    self.remote_settings = RemoteSkillSettings(self.skill_id,
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_backend_client/settings.py", line 48, in __init__
    self.load()
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_backend_client/settings.py", line 177, in load
    self.settings = json.load(f)
                    ^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/__init__.py", line 293, in load
    return loads(fp.read(),
           ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
2023-04-08 09:46:37.748 - skills - mycroft.skills.skill_loader:_create_skill_instance:541 - ERROR - Skill __init__ failed with Expecting value: line 1 column 1 (char 0)
Traceback (most recent call last):
  File "/home/ovos/.venv/lib/python3.11/site-packages/mycroft/skills/skill_loader.py", line 539, in _create_skill_instance
    self.instance._startup(self.bus, self.skill_id)
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 268, in _startup
    raise e
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 252, in _startup
    self._init_settings_manager()
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/mycroft_skill.py", line 90, in _init_settings_manager
    self.settings_manager = SkillSettingsManager(self)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ovos/.venv/lib/python3.11/site-packages/mycroft/skills/settings.py", line 81, in __init__
    self.remote_settings = RemoteSkillSettings(self.skill_id,
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_backend_client/settings.py", line 48, in __init__
    self.load()
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_backend_client/settings.py", line 177, in load
    self.settings = json.load(f)
                    ^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/__init__.py", line 293, in load
    return loads(fp.read(),
           ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
2023-04-08 09:46:37.753 - skills - mycroft.skills.skill_loader:_communicate_load_status:560 - ERROR - Skill skill-ovos-volume.openvoiceos failed to load

error with mycroft.volume.get (only works the first time after boot)

Asking for the current volume or using "quieter" or "louder" only works for the first time after a re-boot.

quieter
>>> Volume set to 40 percent
louder
>>> There seems to be a problem. I could not query the current volume.
>>> An error occurred while processing a request in Volume Skill
quieter
>>> There seems to be a problem. I could not query the current volume.
>>> An error occurred while processing a request in Volume Skill

Unable to load the skill when using ovos-workshop launcher 

2023-04-20 14:30:40.392 - OVOS - ovos_workshop.skill_launcher:load:463 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-volume.openvoiceos
2023-04-20 14:30:40.394 - skill-ovos-volume.openvoiceos - ERROR - Skill initialization failed
Traceback (most recent call last):
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 335, in _startup
    self._init_settings()
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/mycroft_skill.py", line 99, in _init_settings
    if not exists(self._settings_path) and exists(self._old_settings_path):
                  ^^^^^^^^^^^^^^^^^^^
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/mycroft_skill.py", line 193, in _settings_path
    if self.settings_write_path and self.settings_write_path != self.root_dir:
       ^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'VolumeSkill' object has no attribute 'settings_write_path'
2023-04-20 14:30:40.396 - skill-ovos-volume.openvoiceos - WARNING - Skill not fully initialized. Only default values can be set, no settings can be read or changed.to correct this add kwargs __init__(bus=None, skill_id='') to skill class VolumeSkill
2023-04-20 14:30:40.397 - skill-ovos-volume.openvoiceos - ERROR - Traceback:
  File "/home/ovos/.venv/bin/ovos-skill-launcher", line 8, in <module>
    sys.exit(_launch_script())
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skill_launcher.py", line 523, in _launch_script
    launch_plugin_skill(skill_id)
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skill_launcher.py", line 486, in launch_plugin_skill
    skill_loader.load(skill_plugin)
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skill_launcher.py", line 469, in load
    self.loaded = self._create_skill_instance()
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skill_launcher.py", line 419, in _create_skill_instance
    self.instance = skill_creator(bus=self.bus,
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/mycroft_skill.py", line 73, in __init__
    super().__init__(name=name, bus=bus, *args, **kwargs)
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 223, in __init__
    self._startup(self.bus, self.skill_id)
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 355, in _startup
    self.default_shutdown()
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 1783, in default_shutdown
    if self.settings != self._initial_settings:

Dependency on mycroft imports

This skill still has dependencies on mycroft imports rather than OVOS ones. In __init__.py the following lines are used:

from mycroft.skills.core import MycroftSkill, intent_handler, intent_file_handler
from mycroft.util import normalize
from mycroft.util.parse import extract_number

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.