openvoiceos / skill-ovos-volume Goto Github PK
View Code? Open in Web Editor NEWLicense: Apache License 2.0
License: Apache License 2.0
When try to search something on Wikipedia, I got surprised when this skill handled the query!
tell me more about chocolate
>> Volume set to 60 percent
single word intent was previously supported with the old intent that overmatched, but since #31 the "volume" keyword is also required
a new intent should be explicitly added for "louder", and in the future should probably require exact matches when that functionality is introduced
Can we add support for loose requirements?
In docker, when I try to set the volume in Italian, I get:
hey mycroft, imposta il volume a 10
(set volume to 10)Il volume è a 50
(the volume is 50) which is not the answer I am waiting from it. It this is the docker behavior I think it should be documented, but I doubt so, I ALWAYS get 50 as an answer (not even 42)from matrix chat
(edit: replacing screenshot with transcript in case the hosted image ever times out - Chance)
proposed config options:
If I understand this is a direct replacement for skill-ovos-volume
It seems that the skill is looking for something into the backend.
2023-04-08 09:46:37.719 - skills - ovos_utils.messagebus:add:606 - DEBUG - Added event: skill-ovos-volume.openvoiceos.set
2023-04-08 09:46:37.726 - skills - ovos_workshop.skills.base:_startup:262 - ERROR - Skill initialization failed
Traceback (most recent call last):
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 252, in _startup
self._init_settings_manager()
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/mycroft_skill.py", line 90, in _init_settings_manager
self.settings_manager = SkillSettingsManager(self)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ovos/.venv/lib/python3.11/site-packages/mycroft/skills/settings.py", line 81, in __init__
self.remote_settings = RemoteSkillSettings(self.skill_id,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_backend_client/settings.py", line 48, in __init__
self.load()
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_backend_client/settings.py", line 177, in load
self.settings = json.load(f)
^^^^^^^^^^^^
File "/usr/lib/python3.11/json/__init__.py", line 293, in load
return loads(fp.read(),
^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/__init__.py", line 346, in loads
return _default_decoder.decode(s)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
2023-04-08 09:46:37.748 - skills - mycroft.skills.skill_loader:_create_skill_instance:541 - ERROR - Skill __init__ failed with Expecting value: line 1 column 1 (char 0)
Traceback (most recent call last):
File "/home/ovos/.venv/lib/python3.11/site-packages/mycroft/skills/skill_loader.py", line 539, in _create_skill_instance
self.instance._startup(self.bus, self.skill_id)
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 268, in _startup
raise e
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 252, in _startup
self._init_settings_manager()
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/mycroft_skill.py", line 90, in _init_settings_manager
self.settings_manager = SkillSettingsManager(self)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ovos/.venv/lib/python3.11/site-packages/mycroft/skills/settings.py", line 81, in __init__
self.remote_settings = RemoteSkillSettings(self.skill_id,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_backend_client/settings.py", line 48, in __init__
self.load()
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_backend_client/settings.py", line 177, in load
self.settings = json.load(f)
^^^^^^^^^^^^
File "/usr/lib/python3.11/json/__init__.py", line 293, in load
return loads(fp.read(),
^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/__init__.py", line 346, in loads
return _default_decoder.decode(s)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
2023-04-08 09:46:37.753 - skills - mycroft.skills.skill_loader:_communicate_load_status:560 - ERROR - Skill skill-ovos-volume.openvoiceos failed to load
Asking for the current volume or using "quieter" or "louder" only works for the first time after a re-boot.
quieter
>>> Volume set to 40 percent
louder
>>> There seems to be a problem. I could not query the current volume.
>>> An error occurred while processing a request in Volume Skill
quieter
>>> There seems to be a problem. I could not query the current volume.
>>> An error occurred while processing a request in Volume Skill
ATM you have to unmute the state to get back to normal. One step too much imho.
2023-04-20 14:30:40.392 - OVOS - ovos_workshop.skill_launcher:load:463 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-volume.openvoiceos
2023-04-20 14:30:40.394 - skill-ovos-volume.openvoiceos - ERROR - Skill initialization failed
Traceback (most recent call last):
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 335, in _startup
self._init_settings()
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/mycroft_skill.py", line 99, in _init_settings
if not exists(self._settings_path) and exists(self._old_settings_path):
^^^^^^^^^^^^^^^^^^^
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/mycroft_skill.py", line 193, in _settings_path
if self.settings_write_path and self.settings_write_path != self.root_dir:
^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'VolumeSkill' object has no attribute 'settings_write_path'
2023-04-20 14:30:40.396 - skill-ovos-volume.openvoiceos - WARNING - Skill not fully initialized. Only default values can be set, no settings can be read or changed.to correct this add kwargs __init__(bus=None, skill_id='') to skill class VolumeSkill
2023-04-20 14:30:40.397 - skill-ovos-volume.openvoiceos - ERROR - Traceback:
File "/home/ovos/.venv/bin/ovos-skill-launcher", line 8, in <module>
sys.exit(_launch_script())
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skill_launcher.py", line 523, in _launch_script
launch_plugin_skill(skill_id)
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skill_launcher.py", line 486, in launch_plugin_skill
skill_loader.load(skill_plugin)
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skill_launcher.py", line 469, in load
self.loaded = self._create_skill_instance()
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skill_launcher.py", line 419, in _create_skill_instance
self.instance = skill_creator(bus=self.bus,
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/mycroft_skill.py", line 73, in __init__
super().__init__(name=name, bus=bus, *args, **kwargs)
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 223, in __init__
self._startup(self.bus, self.skill_id)
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 355, in _startup
self.default_shutdown()
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 1783, in default_shutdown
if self.settings != self._initial_settings:
This skill still has dependencies on mycroft imports rather than OVOS ones. In __init__.py
the following lines are used:
from mycroft.skills.core import MycroftSkill, intent_handler, intent_file_handler
from mycroft.util import normalize
from mycroft.util.parse import extract_number
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.