Code Monkey home page Code Monkey logo

openvidu-call-react's Introduction

Backers on Open Collective Sponsors on Open Collective License badge OpenVidu Tests Npm version Npm downloads

Documentation Status Docker badge Support badge Twitter Follow

openvidu

Visit openvidu.io

Community Forum

Visit OpenVidu Community Forum

Contributors

This project exists thanks to all the people who contribute.

Backers

Thank you to all our backers! ๐Ÿ™ [Become a backer]

Acknowledgments

OpenVidu has been supported under project "CPP2021-008720 NewGenVidu: An elastic, user-friendly and privacy-friendly videoconferencing platform", funded by MCIN/AEI/10.13039/501100011033 and by the European Union-NextGenerationEU/PRTR.

Sponsors

Support this project by becoming a sponsor. Your logo will show up here with a link to your website. [Become a sponsor]

openvidu-call-react's People

Contributors

banagale avatar csantosm avatar jenkinsopenvidu avatar pablofuente avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

openvidu-call-react's Issues

Version 2.6.0

It seems that the version 2.6.0 is not properly published on npm. You did a fix on gituhub to use the componentWillUnmount lifecycle hook instead of the componentDidUnmount that does not exist. Can you double check that?

Video freezing when 3 people join (after refresh)

We are using this library to create rooms that 3 people can join. Initially when all the 3 people join the room everything is fine. If some of the users will refresh to page though, then the user should be removed from the screen and then join again. But what happens is that the old stream remains frozen, a new stream joins and the 3rd one is like being kicked out.

This is the start of the session:
user_1 screen: u1 u2 u3
user_2 screen: u2 u1 u3
user_3 screen: u3 u1 u2

The user_2 is refreshing the page. One possible scenario will be:
user_1 screen: u1 u2(frozen) u2
user_2 screen: u2 u1 u3
user_3 screen: u3 u1 u2

This is a DOM snapshot before refresh:

<video autoplay="" id="video-undefined" style="transform: rotateY(180deg);"></video>
<video autoplay="" id="video-dpkfbvgujff2loxu_CAMERA_PCTXM"></video>
<video autoplay="" id="video-qdva5burkyo3azoq_CAMERA_WPKOS"></video>

and this is after refresh:

<video autoplay="" id="video-uhlvixevneoe1utf_CAMERA_RDETJ" style="transform: rotateY(180deg);"></video>
<video autoplay="" id="video-qdva5burkyo3azoq_CAMERA_WPKOS"></video>
<video autoplay="" id="video-gcwycld95y6fofwo_CAMERA_ZCFUS"></video>

The id video-qdva5burkyo3azoq_CAMERA_WPKOS should not be there after the refresh and instead the video-gcwycld95y6fofwo_CAMERA_ZCFUS should be in the second place and in the third place we should see another identifier

In some cases it seems that the state is being mutated not by invoking the the setState but by using the splice which can cause some side effects like in the deleteSubscriber function in the VideoRoomComponent.js

Is there an example react that I can use in order to find out if this is a problem of our implementation or if this is a problem of the open-vidu-call-react?

React 17

Hi there.

I'm testing this react library in order to add webrtc capabilities to a hybrid mobile application. As far as I know, the highest version of this library has a dependency on 16. Am I mistaken? If not... have you plans to build a release of the library for react 17? Thanks in advance.

Eslint dependency, prelude-ls creates error in StreamComponent.js jsx

This was odd. Pycharm detected an error on this line of StreamComponent.js due to the naked span tag.

It looks like a downstream dependency of eslint, prelude-ls, causes the naked span in this inline ternary operator to be picked up as utility from that library. This triggers an error there and throughout the rest of the component in the current release.

I don't understand exactly why but it can be resolved simply by adding an empty attribute to the span.

Production build: BrowserslistError: Unknown browser query `dead`

Could the dependency tree be updated as I am getting (production build)

Creating an optimized production build...
Failed to compile.

./src/index.css
Module build failed: BrowserslistError: Unknown browser query `dead`
    at Array.forEach (<anonymous>)

SO + googling indicates that a dependency uses a very old browserslist.
npm ls shows 1.7.7 and 2.11.3 versions used.

Error while working with firefox

The current version of the application, specifically the VideoRoomComponent.js has issues while sharing the screen with Firefox for Ubuntu in version 95.0.1 (64-bit), I'm not sure if this problem is present in other operating systems.

For me, the problem was fixed by changing the following lines, starting in line 397

- const videoSource = navigator.userAgent.indexOf('Firefox') !== -1 ? 'window' : 'screen';
const publisher = this.OV.initPublisher(
    undefined,
    {
-        videoSource: videoSource,
+        videoSource: 'screen',
        publishAudio: localUser.isAudioActive(),
        publishVideo: localUser.isVideoActive(),
        mirror: false,
    },

openvidu-react module not found

hello i m getting a
Can't resolve '/home/pablo/Desktop/openvidu-call-react/library/node_modules/@babel/runtime/helpers/esm/assertThisInitialized'

is this project still being used?

OpenViduReact at version 2.7.1 has a import problem.

Hi @pabloFuente . I'm facing a problem now.

./node_modules/openvidu-react/dist/components/VideoRoomComponent.js
Module not found: Can't resolve '/home/pablo/Desktop/openvidu-call-react/library/node_modules/@babel/runtime/helpers/esm/assertThisInitialized' in '/home/vagrant/workspace/openvidu-tutorials/openvidu-library-react/node_modules/openvidu-react/dist/components'

I checked out current (today's) master branch of openvidu-tutorials and I performed npm install in ./openvidu-tutorials/openvidu-library-react .
The head of ./node_modules/openvidu-react/dist/components/VideoRoomComponent.js was below:

import _classCallCheck from "/home/pablo/Desktop/openvidu-call-react/library/node_modules/@babel/runtime/helpers/esm/classCallCheck";
import _createClass from "/home/pablo/Desktop/openvidu-call-react/library/node_modules/@babel/runtime/helpers/esm/createClass";
import _possibleConstructorReturn from "/home/pablo/Desktop/openvidu-call-react/library/node_modules/@babel/runtime/helpers/esm/possibleConstructorReturn";
import _getPrototypeOf from "/home/pablo/Desktop/openvidu-call-react/library/node_modules/@babel/runtime/helpers/esm/getPrototypeOf";
import _inherits from "/home/pablo/Desktop/openvidu-call-react/library/node_modules/@babel/runtime/helpers/esm/inherits";
import _assertThisInitialized from "/home/pablo/Desktop/openvidu-call-react/library/node_modules/@babel/runtime/helpers/esm/assertThisInitialized";

And then, It's working well when I downgraded openvidu-react from 2.7.1 to 2.6.0.
The latest version seems that have a problem.
I hope this report will be of some help.

Best Regards,
Keisen.

Originally posted by @keisen in #5 (comment)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.