Having a JDBI3 plugin makes the usage much simpler:

Be sure to call Jdbi.installPlugins() upon initialization and all requests will be traced.

The plugin can have a customizeJdbi method that adds the JDBI3 timing collector to the configuration.

JDBI3 deprecated the use of its TimingCollector.

I created a OpenTracingSqlLogger on the same principle as the current timing collector and have the following code in my JDBI3 plugin:

public class OpentracingJdbi3Plugin implements JdbiPlugin {
    private static final Logger LOGGER = Logger.getLogger(OpentracingJdbi3Plugin.class.getName());

    @Override
    public void customizeJdbi(Jdbi jdbi) {
        try {
            OpentracingSqlLogger.configure(jdbi);
        } catch (LinkageError sqlLoggerApiUnavailable) {
            LOGGER.log(Level.WARNING, sqlLoggerApiUnavailable,
                    () -> "Could not configure Opentracing SqlLogger implementation. " +
                            "Are you using JDBI version 3.2 or greater?");
            OpentracingTimingCollector.configure(jdbi);
        }
    }

As you can see it uses the new SqlLogger JDBI3 api if available but falls back on the (deprecated) TimingCollector variant without using reflection.

Hi all,

I was looging at the code and noticed that in OpenTracingCollector.java#L101, the span is started but not put in scope.

I have a use case where we are developping a jdbc driver with native opentracing support. Therefore, when a span is created and started in the driver, it does not register as a child of the jdbi span.

Does it make sense to you to have the jdbi span in scope ?

Thanks and great work !

Should we make this contrib repo a multi-module repository to release separate

• jdbi-opentracing and
• jdbi3-opentracing

maven artifacts?

The split package structure kind of feels 'wrong' and I think having JDBI as provided dependency also feels wrong. JDBI is a transient dependency for this module and ought to be declared as such.

I'm willing to create a PR for this if there is demand for it.

Initializing with

public OpenTracingCollector(Tracer tracer, TimingCollector next)

will result in "next" not being used