opentomb / opentomb Goto Github PK

This is a remnant of #23. It happens in LEVEL1.lua and GYM.lua. Levels are loading but eventually will crash.

The line:

Gui_OutTextXY(30.0, 180.0, "sector = %d", engine_world.Character->current_sector->trig_index);

Crashes the game completely.

setgamef(3,1) caused segmentation fault. This is after VAO merge. Might be related to #57.

As described by Lwmte:

There are some bugs, however - for example, in TR3 Thames Wharf, try to get to a sector with death slide, and you will notice that Lara will disappear on certain sectors on her way, and instead, some garbage white polygons will appear in bottom left corner.

Almost certainly caused by new shader code.

The new collision system is rough at present, but that isn't a point. For some strange reason the coordinates fluctuate wildly. Try this test at the console setgamef(4,3) setEntityPos(player,42787,39352,-6131,177,0,0) then return to game play and tap down once. I've got Lara on top of a crate, on top of it at the back wall, inside the crate, out of the level geometry and even at the opposite front wall of the room at one point!

There is currently an issue which prevents Lara from correctly using a climbable wall.

And if the wall goes up from one room to another a weird bug happens, instead of looped animation, the climbing animation stops and she performs another climb.

In TR3 Lara' house there is an overlapping between room 117 and room 132 below. This produces very weird transition effects when walking or jumping.

In Caves when Lara prepares to make a standing forward jump to the last secret from the ledge, she can only grab the opposite ledge to climb. But in OpenTomb she safely land behind the gap. This also makes jumping around on the blocks in a switch room in Palace Midas unnecessary.

There are just too many. I'm starting this issue to document all of these. Script overrides could use this information to patch them on the fly.

• wrong geometry
  • in Caves setEntityPos(player,17503,48134,-6401,129,0,0)
  • in Palace Midas setEntityPos(player,34010,57306,3548,144,0,0)
  • in Palace Midas setEntityPos(player,75946,37669,4065,122,0,0)
• transparent back-face
  • in Tomb of Qualopec setEntityPos(player,52714,62133,-6656,267,0,0)
• wrong trigger
  • entity 66 in St. Francis' Folly (described in #33)
• wrong static location
  • static 40 in Old Mill (described in #49)
• inaccessible items
  • entity 87 in Palace Midas.
• wrong collisions
  • when Lara got hit by a door and there is no portal she ends up in a limbo.

Compare levels TR4,1 and TR4,10. In one, water animates, in the other, it doesn't. It should in both, of course.

In original TRs, texture info had three types of transparency attributes - OPAQUE (0x00), TRANSPARENT (0x01, magenta-colored zones) and TRANSLUCENT (0x02, alpha-blended). Current version of OpenTomb renderer ignores OPAQUE flag, setting all opaque texinfos to transparent. While it may look normal on a close range, getting farther from these textures may result in "transparency bleeding" on mipmaps from adjacent textures in atlas. This should be fixable by making OPAQUE attribute working again.

A month or two ago, some changes to physics engine were made, which resulted in extremely poor collision detection underwater - Lara can literally swim into any wall, floor or ceiling.

This is visible over certain angles only, e.g. setgamef(1,7) setEntityPos(player,38335,45407,4352,275,0,0) or setgamef(5,1) setEntityPos(player,52875,42308,3584,65,0,0). By rotating the camera the artifacts disappear. It may be related to #40.

Here's a link to screen shots.

When the walk button is tapped once, Lara makes two steps most of the time. But in TR1 she makes just one.

Inventory is empty at the beginning of a level. This was broken in 3a1ee00. Fountains were also broken by the same commit.

Something happened after #20. Lara now collides with plants all over the place.

Lara's ponytail in TR4 has gaps instead of being continuous and smooth, because skinning of hair meshes is not yet implemented. (This also applies to TR2 and TR3, but there that was original)

I'm currently working on changes to the skinning code in general (they already work, but broke animated textures again; I'll push them once that's fixed), so I'd like to claim this one. It will probably end up with TR2 and TR3 getting skinning, as well.

The specular lighting effect ("shiny") in TR4 and TRC is missing and should be added back in.

Note: This bug was not introduced by the shaders. The old code didn't implement it either. Still needs to be fixed, though.

Copied from Tomb Raider forums (post by Joey79100):

When there's a pit behind you, and you press Backwards, Lara will start hoping backwards. Once she's above the empty, she starts falling, playing animation 34 and then 35 (that have StateID 3, that is used for jumping forwards), but it's wrong. She should play animation 93 that has StateID 29 (and without animation 34 before).
This animation and its StateID were considered as unused by Fluen when creating his animation list (and consequently, StateID29 wasn't referenced in the StateID list), because visually it looks the same as animation 35, but actually it is used, and there's a reason.
The problem that exists now is that if you are already pressing the Action key when jumping backwards (to grab the ledge), Lara gets stuck on the edge, switching continuously between animation 22 (starts falling while jumping forward when she hasn't finished the "jump cycle" (when there was a ceiling)), and animation 82 (falls on the ground).
Animation 93 lets you grab a ledge only after 7 frames (not a hardcoded thing, the StateID change is written this way in the animation), while animation 35 lets you do this during the whole animation. So using animation 93 will prevent her from being stuck like she currently does.

Proof that the StateID exists: in TOMB.MAP that was leaked with the May TR1's demo, it's referenced this way:

0001:00013da0 lara_as_fallback_

(StateID 30 is used when shimmying left, and is just after 29 which has a rather clear name)
I don't know if you've written code for this StateID though, but there shouldn't be a lot of differences.
By the way it seems that the speed for animation 95 (ready to grab) is ignored. She's meant to go forward, but in OpenTomb she has no horizontal speed.
The speed she has when she hits a wall while jumping are ignored too.

setgamef(4,4) produced segmentation fault. Broken in 6472097.

But the lighting problems are inconsistent. I get them in the same places but not every time. Seems that they depend on previous actions. Every time I load the level I get different distribution. They appear as very bright white, yellow or totally black colors on Lara and some textures. Here's one place where it sometimes can be seen: setgamef(5,1) setEntityPos(player,46970,42791,-256,270,0,0). And here's another: setEntityPos(player,51278,38426,-256,90,0,0).

I'm not able to attach screenshots for some reason, so here's the link to them.

Seems some idiot forgot to set the matrix correctly in this case. This idiot being me. I'll fix it, I'll just write it down here so I don't forget it.

Disappeared bridges, doors, switch and misplaced medipak, floating in the air. Broken by e661f2e.

When leaving a level with hair (for example by ending the program), an assertion gets triggered because bodies are destroyed while there are still constraints between them.

Happens in many places, e.g. Caves (see #49), Area 51, Old Mill, Streets of Rome. That's after VAO changes.

In TR3's Coastal Village, there is a collision missing on a sector with ladder (Smuggler's passage).

In Tomb of Qualopec, there is a grated door in the main passage to Scion, which is opened on level start-up (activation mask is set). For some reason, it's not affected by HEAVYTRIGGER which should be triggered by boulder. Most likely, additional reverse-engineering of original TR trigger behaviour is needed.

The names of script files are case sensitive and they may not work on a case sensitive filesystem, e.g. in Linux. See comments in ebcccb3.

Happened after VAO merge.

Classic camera will rotate in front on the first collision and stays there indefinitely. This was broken by 8f1992a.

In TR2 Lara' home there are wrong textures in some of the windows. In particular, in the kitchen when you look at the windows from outside.

In St. Francis' folly lever 66 can be operated only once, while in the original it's unlimited. That leads to possible deadlock if player didn't trigger closing a door when entered the room first time.

Broken by db18b55.

As described and shown in video by Lwmte; good examples are TR3 T-Rex, TR4 Crocodile.

This is almost definitely caused by the renormalization stage of mesh loading, which needs to be improved here.

There are some really critical bugs with ladder states, as Lara can't climb up properly from ladder to horizontal surface (it takes few "iterations" for her to finally align correctly), and also she doesn't stop climbing up when she's right under the ceiling, which results in her awkward repositioning.

Fix for the first problem is to finally align Lara's vertical position to multiples of 256 when grabbing.
Fix for the second problem is to perform additional collision checks right above and next to her.

In some areas objects may share the space between its' polygons and surrounding room geometry. Thus it may occlude textures of such objects. One example can be seen in Caves setEntityPos(player,16791,87115,-8960,214,0,0). On a sufficient distance takes place visible flickering apparently caused by Z-fighting. This wasn't so obvious in the original game where camera didn't move during breath animation.

Most likely, it is related to Lua script stack trashing - possibly, in trigger functions section. Good example to check is the end of Temple Ruins with last key in underwater room (sector with two sinks, which also produces short lock-up before crashing).

Possibly, something was broken either with changing UVRotate algorithm, with implementing room shader or with recent renderer/BTA optimizations.

Currently, no additional collision checks are performed on DEATH sectors, only Lara move type is checked. This results in false DEATH triggers, for ex., when Lara is stepping onto trapdoor above lava. This should be fixable by checking if Lara has hit room collisional mesh OR static/entity mesh. Then we ignore DEATH trigger in latter case.

Speed value is not resetting correctly when animation is restarted not from beginning, but from NextFrame frame number.

Opening the Inventory causes a complete crash.

It seems that clipping happens too early. See for example setgamef(4,6) setEntityPos(player,27242,29836,0,16,0,0), then try to rotate camera to the left. Also, try to jump straight up.

As a result of merging polygons with single-sided and double-sided attribute into the same vertex buffer object (with single-sided attribute), double-sided polygons are missing. Most obvious example are trees in TR3 Jungle.

This may be a problem with my shader code.

In TR4 Race For The Iris entity 26 has collision flag set. Requires the same override as in Sacred Lake.

Copied from TRF (post by Joey79100):

When Lara is floating and you want her to dive, she will start going forward (animation 118 then 116) and dive using animation 115. It's good that she can dive when swimming forward as she couldn't in the originals, but now she can't even dive when she's not moving.
In the original games, she didn't start swimming, but dived directly with animation 119. When the animation is triggered, she's rotated at 45° and the animations continue normally. <...> Actually, the animation is forced only when Lara has StateID 33 (floating but not moving). The diving animation never plays during the animation 116 (floating forward), but as soon as animation 117 (stopping animation, with StateID 33) is triggered. So Lara has to be stopped first, and only then she can dive if the Jump key is pressed.
The fact that she stops is certainly hardcoded when the Jump key is pressed though, but it doesn't force the stop animation to play. I think it simulates the releasing of the Up key, or it forces next StateID 33, so when the animation encounters a StateID change with StateID 33, she starts stopping... and as her animation will now be animation 117 which has StateID 33, she will dive at this precise moment.
Fun fact: animation 115, that makes Lara dive while floating forward, wasn't ever played in-game, but there's a StateID change in animation 116 that could trigger it. But it checks for StateID 17 (swimming underwater) instead of StateID 35 (diving)... so either it can't even work, or it works, but as the "stop" behavior has the priority (as it is on the same key), it will not be triggered as she will already be stopping.

This happened after VAO merge.

I have noticed frequent crashes when loading certain levels. Not sure what is causing it, seems to be isolated.

GUI gradients are not properly aligned

Most likely, flag order was changed in TR2 for rewound and wait samples, which results in wrong sound behaviour (e.g., T-Rex steps, Lara sliding, pistols shooting, etc.). Must check original flag meaning in TR2.