openstreetmap-polska / openaedmap-frontend Goto Github PK
View Code? Open in Web Editor NEWMap which shows locations of defibrillators (AEDs) and allows adding new ones.
Home Page: https://OpenAEDMap.org
License: MIT License
Map which shows locations of defibrillators (AEDs) and allows adding new ones.
Home Page: https://OpenAEDMap.org
License: MIT License
Example AED: https://openaedmap.org/#map=19/51.12289/17.05204&node_id=9372773571
There is text in opening_hours
, Closed shouldn't be displayed
Recently added "@beyondtracks/spritezero-cli": "^2.3.1", dependency tries to install mapnik, which seems to doesn't work on Windows. I've spent a lot of time installing dependencies (like C++ and Visual Studio) to make it work but i lost this battle. After deleting @beyondtracks/spritezero-cli": "^2.3.1",
from package.json and run npm install
it works like a charm.
PS It works fine in dev container.
Hello, thank you all for complete this website, I noticed Cristoffs's thread on forum.
Although there aren't so many AED mapped in China, I still want it can be used and more friends to this language's user, maybe some sentence will be optimized in the future during our usage? And translation already done in Weblate:
(The warning is "GeoJSON"->"GeoJSON")
Hi there! I've recently added this AED. However, it doesn't seem to be showing up on OpenAEDMap. Did I tag something incorrectly, or is this a bug on OpenAEDMap's side?
For reference - here's the location on OpenAEDMap
Hi,
Everything is in the title. If the tag is missing in OSM, defibrillator won't show up on openAEDmap.
That bug makes a lot of defib invisible : https://overpass-turbo.eu/s/1mVi
Example : https://www.openstreetmap.org/node/8917378755 & https://openaedmap.org/#map=16.97/42.69234/2.919982
Should allow geocoding as well as pasting coordinates.
Providing coordinates should zoom the map to the location.
Regexp for detecting coordinates to be determined.
Zoom level to be determined.
Geocoder can use Nominatim initially.
What do you think about adding Prettier config and auto-formatting existing code?
current convention of using 2 chars with ISO code will be problematic with some languages like variants of Chinese, Portuguese etc
Example AED: https://openaedmap.org/#map=17/53.46609/18.74759&node_id=9654446743
We should configure opening_hours library: https://github.com/opening-hours/opening_hours.js/#library-api
Also library shouldn't crash the app, I propose displaying opening_hours
as is when lib cannot parse it.
At the moment, it seems like only the access tag is used to change the colour of the AED icons, correct?
That means the map will show (at 21:00) two AEDs tagged as access=yes both with a green icon, even if one has indoor=yes and opening_hours=07:00-17:00, and the other indoor=no + 24/7. You can see that here for example: https://openaedmap.org/#map=16/50.725458/-3.532047 - one of the two green icons here is actually inside a building with restricted opening hours - but you would need to click on each one to find that out.
I think the more important tags for the map to parse would be the indoor and opening hours values, so that the icon can be changed to indicate that access is sometimes restricted.
Also, access=customers seems to correspond with the yellow icon and "Accessible during work hours" - but that doesn't match the wiki description of that tag: https://wiki.openstreetmap.org/wiki/Tag:access=customers
It would seem a bit strange to have an AED solely for use by customers - it might be located in a shop but if a member of the public needs it outside during opening hours they won't be prevented from using it.
Currently if someone edits translation file by hand and makes a mistake the pipelines won't detect it.
It's a bit of a problem that individual AEDs are not showing on a higher zoom level, because we might end up with duplicate entries.
List of languages is not collapsible on mobile. It should either collapse or work like dropdown.
Tested on Firefox forks on Android and on Linux with mobile mode.
Implemented in https://github.com/openstreetmap-polska/openaedmap-frontend/blob/dev/src/components/languageSwitcher.tsx
Screenshot for context, chevron button does nothing.
to make sure people see it and notice the popup saying that marker can be moved
Are there any plans to migrate this repo to TypeScript?
simplify code by moving state that is shared by a lot of elements to global context
There should be buttons that open Google Maps and OSM map navigation. It should be visible in the popup details.
Similarly to https://dopomoha.pl/en/#map=4.26/53.38/20.81
The tags that can be set when adding a new AED should be editable for existing AEDs as well. The "Add AED" interface could then be reused.
It should add the check_date or survey:date automatically.
I had to delete one today which many businesses around believed was still there
Beta Taster Opinion
This is the same bug than #74.
It was closed, but the bug still remains when accessing openaedmap on a mobile phone
'IsCurrentlyOpen' function takes into account browser's timezone. So if we browse AEDs in different timezones there can be a false 'open/closed' label.
on dev env there should appear "debug" language added conditionally in i18n.js
e.g. 3.8k instead of 3800
can round down to nearest 100
investigate whether it can be done in maplibre gl js style or if it needs to be formatted in backend
As more languages are added it becomes harder to track what changed and in which languages some strings need to be added or updated.
I am very satisfied with WebLate - https://hosted.weblate.org/
Add existing or own tutorial to about modal.
Existing tutorial by b-unicycling: https://www.youtube.com/watch?v=kRAmdA9Td80
(replace 'register account' by for example "You can watch this video to learn how" and/or "you only need an OSM-account")
Currently, the icon "Accessible during work hours" is displayed when access=customers
is present. However, the name of the icon implies that it should occur more often. Every AED inside a store would need it, however not every AED in a store is for customers only.
(imagine that, you're dying outside a store and you don't get saved because the AED is for customers only)
According to the OSM wiki, access=customers
means: "Only for customers of the element."
My proposition: any AED that has a value for opening_hours
should get this icon.
As I pointed out on Discord:
Somaliland issue:
https://dev.openaedmap.org/#map=5/9.32/44.67
Northern and Southern borders are also not perfect:
https://dev.openaedmap.org/#map=5/82.65/-25.31
other regions look weird also:
https://dev.openaedmap.org/#map=5/45.63/49.39
currently some deploys fails because warnings are treated as errors for builds, this is difficult to detect when developing locally since local server ignores warnings
The desktop language list is becoming too long. In order for the user to be able to see all languages, the list should be limited to fewer entries and have a scroll bar to allow the user to see all the languages.
If the user zooms in until it switches to the mobile layout (or has a small screen), all languages should remain available as well.
MapComplete has such a menu too.
Related: #63
I think it will be great to present on the separate page list of APPs that show AEDs added in OSM and also via OAED Map (OSMAnd+, Organic Maps etc.) with screenshots.
Also It will be cool to present country specific Apps (like Polish Yanosik) and add info about real-world usage by services (like Polish firefighters).
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.