openstack-charmers / charm-cinder-backup-swift-proxy Goto Github PK

https://github.com/openstack-charmers/charm-cinder-backup-swift/blob/bc764aa10cfb52f8405c45c78b73349966eb13f5/tests/tests.yaml#L11

There appears to be a reference to Zaza functional tests but I do not find them in the upstream repositories.

Would you mind opening a PR on https://github.com/openstack-charmers/zaza-openstack-tests with the setup and test code.

Note that OpenStack tests should be prefixed by the zaza.openstack module path, and you need to add both the zaza and zaza-openstack-tests repositories to src/test-requirements.txt

The amulet tests should also be removed.

https://travis-ci.org/openstack-charmers/charm-cinder-backup-swift/builds/548525410

https://github.com/openstack-charmers/charm-cinder-backup-swift/blob/3c0fbce12fb91394687ea5b7ae474dbb2d982d31/tox.ini#L42

Please update to use stestr, you can find examples of how here:
https://review.opendev.org/#/q/project:%255Eopenstack/charm.*+stestr

https://github.com/openstack-charmers/charm-cinder-backup-swift/blob/32aeb1ea768876ad416776ecd1be90928df13612/src/lib/charm/openstack/cinder_backup_swift.py#L26

As the functional test demonstrates and and as laid out here openstack-charmers/zaza-openstack-tests#24 (comment)

It should probably just be removed as the principal will restart the service after writing the config, you would have to validate this with the functional test of course.