openscilab / nava Goto Github PK

Description

Add logo

Description

Decorators cannot handle keyword arguments

Steps/Code to Reproduce

>>> from nava import play
>>> play(sound_path="alarm.wav")

Expected Behavior

Play sound

Actual Behavior

Traceback (most recent call last):
    ...
IndexError: tuple index out of range

Operating System

Windows 10

Python Version

Python 3.8

nava Version (Use : nava.__version__)

Nava 0.1

Describe the feature you want to add

Supporting playing sound in Jupyter notebook environment

Describe your proposed solution

No response

Describe alternatives you've considered, if relevant

No response

Additional context

No response

Description

Support async mode

Description

The decorator hides the parameters of the function

Operating System

Windows 10

Python Version

Python 3.8

nava Version (Use : nava.__version__)

Nava 0.1

We should use @wraps from functools module like here

Description

Support loop

Description

Orphan processes bug

Steps/Code to Reproduce

import time
from nava import play, stop
for _ in range(1000):
    sound_id = play("alarm.wav", async_mode=True)
    time.sleep(4)
    stop(sound_id)

Expected Behavior

Normal behavior

Actual Behavior

Receiving numerous resource warnings related to a large number of orphan processes

Operating System

Ubuntu 18.04

Python Version

Python 3.9

nava Version (Use : nava.__version__)

Nava v0.3

Description

Add Nava to Conda

Description

Add tests for different platforms

• Linux
• macOS
• Windows

Description

We use subprocess to play sound in Linux and macOS (__play_linux and __play_mac functions) so we should prevent possible shell injections from sound_path.

1. It's better to implement this method as a decorator (like @input_check)
2. We know that sound_path should be a path

Description

Add CLI options

nava alarm.wav

nava --file="alarm.wav"