openmindculture / ingosfraktalistheme Goto Github PK

• system config service not working properly (see. 2022_1)
• logger not working properly (see 2021_3)
• incorrect / inconsistent capitalization of folder names?
• localize every hard-coded template string using snippets (lesson 10)
• localize images that contain text: best practice?
• loop fake shops: paginate large amount of data: best practice?
• we should not need a full path to loop over our custom data in twig
• check and fix deprecations ...
  • #4
  • #5
• analyze, fix, refactor using tooling (PhpStan, SonarLint, built-in PhpStorm tools, ...)
• recap, read, and understand everything that I did (would-be code review preparation)

Apart from the deprecations mentioned in https://github.com/shopware/platform/blob/0e704e58bdb4b22bd611a5f2fe66d24c9c36a6a4/changelog/_unreleased/2022-05-23-internal-repositories.md there are more problems.

List of all problems, warnings, deprecations shown in the existing code using the latest (November 2022) PhpStorm, Shopware Core, Shopware plugins and toolbox (shyim/FroSh):

• What about psh.phar storefront:build? This throws a lot of deprecation warnings about CSS processing in your theme engine now. What to use instead? Any bin/console equivalent?
• use Shopware\Core\Framework\DataAbstractionLayer\Search\Criteria; was deprecated, used in FooterSubscriber, no deprecation anymore
• use Shopware\Core\Framework\DataAbstractionLayer\Search\Filter\EqualsFilter; was deprecated, used in FooterSubscriber, no deprecation anymore
• pagelet->addExtension is deprecated (in IngoSFraktalistheme/src/Storefront/Subscriber/FooterSubscriber.php)
  • should not be deprecated anymore in Shopware 6.5;
  • ensure that the second parameter (extension) can never be null, see https://stackoverflow.com/questions/72968625/replacement-for-deprecated-shopware-6-addextension-method
• [Annotations] Annotation is deprecated (@RouteScope(scopes={"api"}) in src/Core/Api/DemoDataController.php)

Shopware "deprecated EntityRepositoryInterface, the class will be removed with next major, type hint with EntityRepository instead".
https://github.com/shopware/platform/blob/0e704e58bdb4b22bd611a5f2fe66d24c9c36a6a4/changelog/_unreleased/2022-05-23-internal-repositories.md

Using this theme stub to follow Shopware academy tutorials has filled up the code with features that do not belong in a theme, like an API route to generate fake shop finder data.

This should be removed, or moved to another repository so we can actually develop a simple theme!

TODO:
[ ] tag existing tutorial code
[ ] remove tutorial code