openlink / structured-data-sniffer Goto Github PK

There's some missing sanitation/escaping of HTML in certain case, such as for schema:mainContentOfPage objects.

For example, using the plugin on the page at https://github.com/deiu/html-sanitation/blob/master/README.md displays the select element generated by the keygen element.

This passes the SDTT, but not in the Chrome plugin.

{
  "@context": "http://schema.org",
  "@type": "CreativeWork",
  "isFamilyFriendly" : "true",
  "dateCreated" : "2017-10-12T16:46:27+00:00",
  "dateModified" : "2017-10-18T15:30:43+00:00",
  "headline": "Headline",
  "genre": "Technology and Innovation",
  "description": "Some description"                
}

Does not parse. It tries to put the site URL before it.

JSON-LD discovered, but fails syntax checking by parser:
Error: Syntax error: unexpected "<http://site.url/Technology%20and" on line 6.

Is this an error with the plugin or related to:
schemaorg/schemaorg#51

This is a great plugin! It was extremely useful for helping me debug as I add microdata to my website.

It would be appreciated if there was a signed Firefox plugin, though, so that I can install the plugin permanently.

Having in meta something like

<link rel='preconnect' href='//static.hotjar.com' />
<link rel='preconnect' href='//adservice.google.com' />
	
<link rel='dns-prefetch' href='//static.hotjar.com' />
<link rel='dns-prefetch' href='//vars.hotjar.com' />

Extension shows

Expected should be:

https://static.hotjar.com
https://vars.hotjar.com

Basically protocol should be processed, not url appended to the root domain.

When watching a movie on Netflix, I see this on the browser console:

Unhandled promise rejection TypeError: promise.then is not a function
Stack trace:
wrapPromise/<@resource://gre/modules/ExtensionCommon.jsm:490:9
Promise@moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6/lib/jsonld.js:9940:7
wrapPromise@resource://gre/modules/ExtensionCommon.jsm:489:14
callAsyncFunction@resource://gre/modules/ExtensionCommon.jsm:697:12
stub@resource://gre/modules/Schemas.jsm:2297:22
is_data_exist@moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6/sniffer.js:366:13
@moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6/sniffer.js:933:13
j@moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6/lib/jquery-3.1.0.min.js:2:29566
Deferred/then/g/</k<@moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6/lib/jquery-3.1.0.min.js:2:29882
 jsonld.js:9873:11
	onUnhandled/</result< moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6/lib/jsonld.js:9873:11
	module.exports moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6/lib/jsonld.js:4354:27
	onUnhandled/< moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6/lib/jsonld.js:9867:16
	module.exports moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6/lib/jsonld.js:10148:25
	<anonym> moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6/lib/jsonld.js:4296:7
	run moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6/lib/jsonld.js:4282:5
	listener moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6/lib/jsonld.js:4286:3

The copyright notice in sniffer.js suggests that moz-extension://d13b1eab-e311-45ff-b72d-d871010a20d6 is the OpenLink Structured Data Sniffer.

e.g., if schema:image pointing to .svg - it is not displayed in the document metadata

I have an issue where if I directly load a .ttl file in Firefox, the plugin intercepts the request and creates a tab with contents moz-extension://6d962960-a724-3b4f-8391-4392f21ef52e/page_panel.html?url=https%3A%2F%2Fexample.net%2Ftest%2Fv1%2Fpathdeets%2Fmy_turtle.ttl&type=turtle&ext=.

Because the document would normally trigger the "download file" dialog (rather than loading in a tab), there is no way to see the original URI that triggered the load. The only place it is displayed in the plugin panel is as a url-encoded query parameter in the tab URI.

It would be good to at print the original URI somewhere so it's easy to copy/paste/modify.

Thanks!

When I have this add-on enabled I am unable to view XML pages in Firefox. The console shows:

XML Parsing Error: not well-formed Location: Line Number 1, Column 22:

If I disable the OpenLink Structured Date Sniffer add-on then the XML page displays correctly.

My Firefox browser automatically updated OSDS to v2.18.3, which is said to have been released in November 2020 (under the Mozilla Public License, btw). I can't find any mention of new releases in GitHub after 2.15 (as release) or 2.16.1 (as tag).

Are you still maintaining this addon? Could you update this repo with the latest releases?

Not sure if this is an issue with the structure of this specific site's code, or the plugin.

https://www.allcarepharmacy.com/

The plugin only pulls three entities. You can see on the Structured Data Linter results for the page, there are many more it should be picking up.

(I'm on Firefox 51.0.1 on Windows 8)

the official firefox addon release installs but doesn't respond at all. The icon button doesn't perform any action, doesn't even behave like a button on hover. Only thing I see on browser console is

onMsg=TypeError: request is null

Debugging the JS I could only find this line in panel.js

Browser.api.runtime.onMessage.addListener(function(request, sender, sendResponse)

request parameter is null, hence it throws exception in its first line.

On other hand, the link to the last version of FF extension on github doesn't work.

Some pages, instead of embedding structured data, only provide a reference to it for example with rel="meta" http://patterns.dataincubator.org/book/autodiscovery.html

Possibly also using rel="alternate"

`

or rel="describes"

<link rel="describes" href="https://data.alice.example/12312321441#this"/>

maybe sniffer could try following all such links using appropriate content negotiation?

Newbie question: I now get an error at Europeana after a new release in Europeana

_JSON-LD discovered, but fails syntax checking by parser:

jsonld.InvalidUrl: Dereferencing a URL did not result in a valid JSON-LD object. Possible causes are an inaccessible URL perhaps due to a same-origin policy (ensure the server uses CORS if you are using client-side JavaScript), too many redirects, a non-JSON response, or more than one HTTP Link Header was provided for a remote context._

on page people/24551-rosa-mullodzhanova.html

Question: Is this a problem in the sniffer or should Europeana change something

Close this as soon as there is a Safari plugin available ;)

Hello,
It does not look like this extension works with XHTML (application/xhtml+xml).
Example with my own Web site https://alexandre.alapetite.fr.

If lang="" or xml:lang="" is used, it is supposed to signal to the RDFa processor to not assign a language tag. However, it appears to apply the lang of the parent/document e.g.:

bibo:uri "urn:nbn:de:0074-1593-2"@en at http://ceur-ws.org/Vol-1593/

It should be bibo:uri "urn:nbn:de:0074-1593-2".

Hi,

I used the extension "OpenLink Structured Data Sniffer" (in version 2.15.2) on Google Chrome.

1/ Open the webpage https://psh.techlib.cz/skos/PSH13814 in Google Chrome
2/ Click on the link "Heslo ve formátu JSON-LD" (with your mouse) in left column
3/ A new tab is opened (and have focus) : chrome-extension://egdaiaihbdoiibopledjahjaihbmjhdj/page_panel.html?url=https%3A%2F%2Fpsh.techlib.cz%2Fapi%2Fconcepts%2FPSH13814%3Fformat%3Denriched&type=jsonld&ext=
4/ On the other browser tab, the json-ld in displayed but the extension don't work.

Settings of the extension : defaults settings

Expectation: -

Reality: The new tab is opened with a "JSON-LD" empty tab.

Thanks for this greatfull extension.

Hi, I was looking at the code to see how the metadata is extracted (to perhaps use it or learn from it, in my own extension based on the WD extension.

That WD extension is licensed as GPL v3. Now, I was reading about the compatibility of GPL v2 / v3 and it seems any codes can't be mixed in this situation: "According to the License compatibility matrix from GNU, if you link your GPLv2 (or later) software with an LGPLv3 library, the effective license for the product becomes GPLv3." - *.

Is there a good reason to have this strict GPL v2 situation, which outweighs the license incompatibility with other projects going forward?

When I open http://techascent.com/blog/tvm-for-the-win.html and press "Show Document Metadata" the popup pops up and displays "Processing data ..." with a spinner. Afterwards nothing happens, even if I wait for several minutes.

Structured Data Sniffer 2.16.10, Firefox 63.0.3, Fedora 29