Parser expects prefix in data:

global replace @"IVEF by @"

What steps will reproduce the problem?
1. qmake
2. mingw32-make

What is the expected output? What do you see instead?
ld.exe: cannot find -livef
collect2: Id returned 1 exit status

What version of the product are you using? On what operating system?
Platform: Windows XP SP2
Software: QT SDK 2009.02 (same result with QT 4.5)

Please provide any additional information below.
This error exists when trying to compile examples "illisten". 
Please note that there is no errors in compiling QT tutorial samples and
"ivef-qt".

Thanks.

Concerns the xsd2code core generation tool.

The code generation tool creates a toXML method to produce XML. For an 
attribute of type xs:boolean it sets the value to "yes" or "no". 

However W3C specifies: An instance of a datatype that is defined as 
·boolean· can have the following legal literals {true, false, 1, 0}.

Concerns the xsd2code code generator tool.

The tool provides member hasXYZ()-functions for classes, which are not const 
functions. This can be troublesome when developers are using the generated 
code with const objects.

Easy to fix by making the functions const, which does not effect the usage 
of the generated code.

SOG, Breadth and Length cannot be zero according to the schema, however such 
values can occur 
when using AIS

What steps will reproduce the problem?
1. Create a string that holds more than one message
2. give it to [parser parse:theString]
3. parser will exit after the first message

What is the expected output? What do you see instead?
- i would expect events for all messages

This went unnoticed since most TCP frames have only a single message or less

The generated c++ code contains classes whose member variables are not
initialized. If these member vaiables are not set by the application, the
XML result contains undefined values.

replace <Cocoa/Cocoa.h> with <Foundation/Foundation.h>

a vesseldata has an array of static datas but access to it is hidden from
the implementor, it would lead to easier code if access was available:

for (staticData *data in [vesselData staticDatas]) .....

iso 

for (int i=0; i<[vesseldata numberOfstaticDatas];i++) {
   staticdata *data = [vesselData staticDataAtIndex:i];

implement allValues and allKeys as in normal Objc Container

should be: (also check Qt) 

 index[0] = [m_dataBuffer rangeOfString:@"</MSG_VesselData>" options: 
NSBackwardsSearch].location + strlen("</MSG_VesselData>");
     index[1] = [m_dataBuffer rangeOfString:@"</MSG_LoginRequest>" options: 
NSBackwardsSearch].location + strlen("</MSG_LoginRequest>");
     index[2] = [m_dataBuffer rangeOfString:@"</MSG_LoginResponse>" options: 
NSBackwardsSearch].location + strlen("</MSG_LoginResponse>");
     index[3] = [m_dataBuffer rangeOfString:@"</MSG_Ping>" options: 
NSBackwardsSearch].location + strlen("</MSG_Ping>");
     index[4] = [m_dataBuffer rangeOfString:@"</MSG_Pong>" options: 
NSBackwardsSearch].location + strlen("</MSG_Pong>");
     index[5] = [m_dataBuffer rangeOfString:@"</MSG_ServerStatus>" options: 
NSBackwardsSearch].location + strlen("</MSG_ServerStatus>");
     index[6] = [m_dataBuffer rangeOfString:@"</MSG_Logout>" options: 
NSBackwardsSearch].location + strlen("</MSG_Logout>");
     index[7] = [m_dataBuffer rangeOfString:@"</MSG_ServiceRequest>" options: 
NSBackwardsSearch].location + strlen("</MSG_ServiceRequest>");

Concerns the xsd2code code generation tool.

Generated documentation in a class header is not properly commented when 
it contains newlines in the XSD (causes compilation errors).

currently we only have stringValueWithLead which is often called with @""

setString does not exist for NSData, use setLength: 0 to reset the buffer

Generating XML output using the library, there are no functions to check if
all the required attributes/elements are filled. Currently it is possible
to output invalid XML.

e.g. in static data StringValue

-        [xml appendString: [NSString stringWithFormat:@"%d", m_objectType]];
+        [xml appendString: [NSString stringWithFormat:@"%f", m_objectType]];

Currently the code is case sensitive. This causes problems on systems that
are actually case sensitive. Please make all code lower case.

the xsd type fixed is not respected

detected in objc

It would be usefull to implement a filter on attributes. 

This could be done to implement a stack in IVEFHandler which pushes attributes 
(key/value) (like 
"PosReport.SOG = 12" on  a stack, then print the whole MSG_VesselData in the 
endElement call.

Before printing the report it should be evaluated if the attribute specified by 
--filterattribute is 
matched by --filtervalue

eg. ilisten --filterattribute=MMSI --filtervalue=0024* returns dutch vessels.

perhaps --filterequals --filterregexp --filtersmaller --filtergreater is 
better...

one could use a vistor pattern in stread of having the parser know the objects 
(more elegant)

Concerns the xsd2code code generation tool (generation of Qt code).

In certain cases floating point types are converted to scientific 
notation, while in the XSD the type is specified as xs:decimal. A valid 
decimal format is expected.

--- IVEFStaticData.m    (revision 387)
+++ IVEFStaticData.m    (working copy)
@@ -25,84 +25,94 @@
         m_maxAirDraughtPresent = false;
         m_maxDraughtPresent = false;
         m_deepWaterVesselindPresent = false;
         m_dateFormatter = [[NSDateFormatter alloc] init];
         [m_dateFormatter setDateFormat:@"yyyy-MM-dd'T'HH:mm:ss.SSS"];
     }
     return self;
 }

+- (void)dealloc {
+   [m_id release];
+    [m_sourceName release];
+    [m_callsign release];
+    [m_shipName release];
+    [m_ATONName release];
+    [m_natLangShipName release];
+    [m_portOfRegistry release];
+    [m_countryFlag release];
+   [super dealloc];    
+}
+

What steps will reproduce the problem?
1. introduce some illigal XML 
2. cat illigal.xml | testqt
3. no error is provided

What is the expected output? What do you see instead?
i would expect to see: illigal input statement via a signal so i can handle it 
in the client

Please use labels and text to provide additional information.

Purpose of code changes on this branch:

new version of the interface

When reviewing my code changes, please focus on:

- completeness
- documentation
- clarity
- bounding/limiting of ranges

After the review, I'll merge this branch into:
/trunk

                NSDateFormatter *inputFormatter = [[[NSDateFormatter alloc] init] autorelease]; // 
2008-11-16T20:59:25.003
                [inputFormatter setDateFormat:@"yyyy-MM-dd'T'HH:mm:ss.SSS"];
                NSDate *val = [inputFormatter dateFromString:value];
                //NSDate * val = [NSDate dateWithString: value]; // assume "yyyy-MM-ddThh:mm:ss.zzz"

in ivefparser.m init:

        m_dataBuffer = [[NSMutableString alloc] init];

- (void)parser:(NSXMLParser *)parser parseErrorOccurred:(NSError *)parseError {
    NSLog(@"ILParser.parseErrorOccured: %@", parseError);
    [[NSNotificationCenter defaultCenter] postNotificationName:@"ILParserError" object: self 
userInfo:parseError];
}

should  be:

- (void)parser:(NSXMLParser *)parser parseErrorOccurred:(NSError *)parseError {
    NSLog(@"ILParser.parseErrorOccured: %@", parseError);
    [[NSNotificationCenter defaultCenter] postNotificationName:@"ILParserError" object: self 
userInfo:[NSDictionary dictionaryWithObject: parseError forKey: @"Error"]];
}

Objc parser checks on qualifiedname, but should be elementName

since all qNames are hashable one could make a hashtable and jump to the 
correct parser routine 
without walking the if tree

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


Please use labels and text to provide additional information.

c++ generation qt:

The xsd2code tool uses only the minimum and maximum value of an attribute
if both are defined.

The w3c xml schema specification allows only the minimum value or only the
maximum value.

Currently checks (derived from the minInclusive and maxInclusive) are added
to the c++ code if both are defined (schema).

replace: NSMutableString *xml = [NSString
with: NSMutableString *xml = [NSMutableString

Application will build and run correct using mingw compiler but no output
to console is reported.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


Please use labels and text to provide additional information.

it should not be "get<name>" but just <name>

concerns xsd2code tool

The sourcecode generation tool does not use the minOccurs and maxOccurs
(attributes of elements, xml schema). This is desirable to ensure valid xml.

ilisten does not demonstrate the toXML function

It would be nice if the generated c++ header files contains docygen
comments. The annotations of the XML schema can be used.

Index: IVEFParser.m
===================================================================
--- IVEFParser.m    (revision 387)
+++ IVEFParser.m    (working copy)
@@ -9,496 +9,539 @@
     if (self != nil) {
         m_dataBuffer = [[NSMutableString alloc] init];
         m_objStack = [[NSMutableArray alloc] init];
-        [self setDelegate: self]; // we are our own delegate
     }
     return self;
 }

+- (void)dealloc {
+    [super dealloc];
+   [m_dataBuffer release];
+   [m_objStack release];
+}
+


+   if (indexMax > 30) {
+       NSString *messages = [m_dataBuffer substringToIndex: indexMax];
+       [m_dataBuffer deleteCharactersInRange:NSMakeRange(0, indexMax)];
+       //NSLog(@"messages:\n %@", messages);
+       //NSLog(@"buffer:\n %@", m_dataBuffer);
+       
+       //[self initWithData: [messages
dataUsingEncoding:NSASCIIStringEncoding]]; // should probably not call init
more than once
+       //[self parse];
+       
+       
+       // create a seperate memory pool, so we can quickly deallocate temp
objects generated by the parser
+       NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
+           
+       NSXMLParser *tempParser = [[NSXMLParser alloc] initWithData:[messages
dataUsingEncoding:NSASCIIStringEncoding]];
+       //AQXMLParser *tempParser = [[AQXMLParser alloc] initWithData:[messages
dataUsingEncoding:NSASCIIStringEncoding]];
+       [tempParser setDelegate:self];
+       [tempParser parse];
+       [tempParser release];
+       //[messages release]; // is already autoreleased!!
+       
+       [pool release];
+       
+   } else {
+       return false; // not enough data in string
+   }
+   if (!cont) {
+       [m_dataBuffer setString: @""];
+   }
+   return true;
+}

don't retain, they are already allocated once, release or auto release after 
the event

- (void)     parser:(NSXMLParser *)parser 
      didEndElement:(NSString *)qualifiedName
       namespaceURI:(NSString *)namespaceURI
      qualifiedName:(NSString *)qualifiedName2 {
    // check all possible options
    //NSLog(@"end %@", qualifiedName);
    if ([qualifiedName isEqualToString: @"Header"]) {

        IVEFHeader *obj = (IVEFHeader*) [m_objStack lastObject];
        //[obj retain];
        [m_objStack removeLastObject];
        if ( [[m_objStack lastObject] isKindOfClass: [IVEFMSG_VesselData class]]) {
                [((IVEFMSG_VesselData*) [m_objStack lastObject] ) setHeader: obj ];
        }
        if ( [[m_objStack lastObject] isKindOfClass: [IVEFMSG_LoginRequest class]]) {
                [((IVEFMSG_LoginRequest*) [m_objStack lastObject] ) setHeader: obj ];
        }
        if ( [[m_objStack lastObject] isKindOfClass: [IVEFMSG_LoginResponse class]]) {
                [((IVEFMSG_LoginResponse*) [m_objStack lastObject] ) setHeader: obj ];
        }
        if ( [[m_objStack lastObject] isKindOfClass: [IVEFMSG_Ping class]]) {
                [((IVEFMSG_Ping*) [m_objStack lastObject] ) setHeader: obj ];
        }
        if ( [[m_objStack lastObject] isKindOfClass: [IVEFMSG_Pong class]]) {
                [((IVEFMSG_Pong*) [m_objStack lastObject] ) setHeader: obj ];
        }
        if ( [[m_objStack lastObject] isKindOfClass: [IVEFMSG_ServerStatus class]]) {
                [((IVEFMSG_ServerStatus*) [m_objStack lastObject] ) setHeader: obj ];
        }
        if ( [[m_objStack lastObject] isKindOfClass: [IVEFMSG_Logout class]]) {
                [((IVEFMSG_Logout*) [m_objStack lastObject] ) setHeader: obj ];
        }
        if ( [[m_objStack lastObject] isKindOfClass: [IVEFMSG_ServiceRequest class]]) {
                [((IVEFMSG_ServiceRequest*) [m_objStack lastObject] ) setHeader: obj ];
        }
        [obj release]; 
    }
    else if ([qualifiedName isEqualToString: @"MSG_VesselData"]) {

        IVEFMSG_VesselData *obj = (IVEFMSG_VesselData*) [m_objStack lastObject];
        //[obj retain];
        [m_objStack removeLastObject];
        //NSLog(@"sending");
        [[NSNotificationCenter defaultCenter] postNotificationName:@"NewIVEFMSG_VesselData" 
object: self userInfo:[NSDictionary dictionaryWithObject: obj forKey: 
@"Data"]]; 
        [obj release]; 
    }

Xcode default builds an application and not a commandline tool

IVEF is not 2 chars, use IL

time conform ISO 8601 should be followed by a Z for zulu indication (is now
ommited)

Library should be able to process also strings without the Z for backwards
compatibilty.

The source id field in vessel and voyage data is only 20 chars, at least 40 are 
required

encode the string values according to xml standard (w3c)

 html.replace('&', "&");
607          html.replace('<', "&lt;");
608          html.replace('>', "&gt;");
609          html.replace('"', "&quot;");

    [xml appendString: [NSString stringWithFormat:@"%d", m_encryption]];

probably all ints are sent as floats (%f)

- (void)     parser:(NSXMLParser *)parser 
    didStartElement:(NSString *)elementName
       namespaceURI:(NSString *)namespaceURI
      qualifiedName:(NSString *)qualifiedName
         attributes:(NSDictionary *)attributeDict {
    // check all possible options
    if ([elementName isEqualToString: @"MSG_LoginRequest"]) {
        ILMSG_LoginRequest *obj = [[ILMSG_LoginRequest alloc] init];
        [obj setAttributes: attributeDict];
        [m_objStack addObject: obj ];
    }

object is allocated but never released!

the sdk requires miliseconds to be present, but according to:
http://www.w3.org/TR/xmlschema-2/#dateTime this is not required. The
documentation in the XSD does specify miliseconds, this should be updated
too. (esp. for ETA/ATA)

Using the attached example XSD to generate (Qt) code, the code generation 
tool creates one "Body" class with multiple occurrences of the same method.

This result in conflicts during compilation:

Body.h:64: error: ‘void Body::addReferencedData(ReferencedData)’ cannot be 
overloaded
Body.h:51: error: with ‘void Body::addReferencedData(ReferencedData)’
Body.h:68: error: ‘ReferencedData Body::getReferencedDataAt(int) const’ 
cannot be overloaded
Body.h:55: error: with ‘ReferencedData Body::getReferencedDataAt(int) 
const’
Body.h:73: error: ‘int Body::countOfReferencedDatas() const’ cannot be 
overloaded
Body.h:60: error: with ‘int Body::countOfReferencedDatas() const’
Body.h:112: error: declaration of ‘QVector<ReferencedData> 
Body::m_referencedDatas’
Body.h:110: error: conflicts with previous declaration 
‘QVector<ReferencedData> Body::m_referencedDatas’
Body.h:113: error: declaration of ‘bool Body::m_referencedDataPresent’
Body.h:111: error: conflicts with previous declaration ‘bool 
Body::m_referencedDataPresent’
Body.cpp:68: error: redefinition of ‘void Body::addReferencedData
(ReferencedData)’
Body.cpp:50: error: ‘void Body::addReferencedData(ReferencedData)’ 
previously defined here
Body.cpp:74: error: redefinition of ‘ReferencedData 
Body::getReferencedDataAt(int) const’
Body.cpp:56: error: ‘ReferencedData Body::getReferencedDataAt(int) const’ 
previously defined here
Body.cpp:80: error: redefinition of ‘int Body::countOfReferencedDatas() 
const’
Body.cpp:62: error: ‘int Body::countOfReferencedDatas() const’ previously 
defined here

Only the Qt lib comes close to "well commented" code, the others do not.

this can be easily overcome by expanding the xsd2code tool with more comment 
output.