Suggestion: Implement Go linting about of-watchdog HOT 4 OPEN

I've seen linting used in the following projects to enforce Code "policy":

• Docker: https://github.com/moby/moby/blob/master/hack/validate/gometalinter
• Virtual-kubelet: https://github.com/virtual-kubelet/virtual-kubelet/blob/master/.circleci/config.yml#L12-L17
• mesos-dns: https://github.com/mesosphere/mesos-dns/blob/master/circle.yml#L35
• Kubernetes: https://github.com/kubernetes/repo-infra/blob/master/verify/go-tools/verify-gometalinter.sh

It's not so much of a request, as more of a codification of the practices of the project.

from of-watchdog.

Derek add label: proposal

from of-watchdog.

@sargun thanks for writing up your proposal and for covering the points suggested in the contribution guide 👍

Linting and static code analysis is definitely something very widely used with OOP languages like Java and C# (sometimes with the Python community and PEPs), but I haven't encountered this much in the Go community. This is the first request for linting since the project started in 2016.

Cons: Sometimes linters can be annoying

This question is placed in the wrong repo - if linting is to be introduced and followed / honoured then it needs to be part of the overall contribution process for the whole project.

At this time I do not see linting as offering strong benefits but I may change my mind in the future if I see enough value for the cost to implement across the whole project. That said I tend to use a less strict linting implicitly through my IDE when making patches.

from of-watchdog.

well lucky me, if this is still in progress, might help with linter rules?

I use this for projects and I have scraped countless linter rules from golangci-lint configs because sometimes some rules are the same but maintained by 2 different projects. We can always customize linter settings but I prefer one config for one org that everyone agrees, it is super easy to customize but metalinters are painful to customize so we use defaults of these rulesets (gocritic/revive/govet/staticcheck)

https://gist.github.com/MrWormHole/250a8a1f78ca17c059b8ce075bbc28ec

I can see from @sargun 's list

    - golint (this is no longer valid, superceeded by revive of Grafana labs)
    - gosec (valid)
    - interfacer (deprecated no longer a good practice)
    - unconvert (valid)
    - dupl (valid but requires a config to ignore test files)
    - goconst (valid)
    - gocyclo (valid)
    - goimports (valid)
    - misspell (valid but UK and US folks fight for this a lot, we use UK setting for the language, I don't like this linter)
    - scopelint (absolute dead and no longer used, superceeded by [exportloopref](https://github.com/kyoh86/exportloopref))
    - gofmt (valid)

from of-watchdog.