openddrmobi / openddr-csharp Goto Github PK

Along the lines of OpenDDRdotORG/OpenDDR-Java#31

See OpenDDRdotORG/OpenDDR-Java#19

Hello
I ve got this exception "collection was modified; enumeration operation may not execute" during service initialisation.

It is thrown in Oddr.Builders.Devices.TwoStepDeviceBuilder.AfterOrderingCompleteInit after the first call of SortElement(step1Token);

foreach (String step1Token in orderedRules.Keys)
{
            SortElement(step1Token);
}

This exception was thrown because SortElement modifies orderedRules.Keys collection.

To solve the issue, I changed the code by :

String[] stringKeys = new String[orderedRules.Keys.Count];
orderedRules.Keys.CopyTo(stringKeys, 0);
foreach (String step1Token in stringKeys)
{ 
            SortElement(step1Token);
}

Similar DLL for both C# and VB Classifier

Running the console application of the OpenDDR-Simple solution hits an exception when running againt the 1.32 release file-set, it works fine with the 1.31 release though.
I'm super new to this project and am not yet capable of giving a more qualified answer or even issue a PR. So here's the exception I get:

W3c.Ddr.Exceptions.InitializationException
  HResult=0x80131500
  Message=
  Source=<Cannot evaluate the exception source>
  StackTrace:
<Cannot evaluate the exception stack trace>

Inner Exception 1:
Exception: Can not parse oddr.ua.device.builder.path: C:\devicedetection\devicedata\BuilderDataSource.xml

As said, replacing all the files in the devicedata directory with the 1.31 release package works.