RFC: switch from pullapprove to native github process about selinux HOT 9 CLOSED

I also suggest to disable the "squash and merge" and "rebase and merge" options (mostly personal preference, as they clobber the contributor's commits, and with that, their GPG signing)

Done this, too.

from selinux.

SGTM

from selinux.

SGTM 👍

from selinux.

I think it's ok to configure "min number of approvals"; maintainers can still "use the force" if really needed.

from selinux.

@giuseppe WDYT?

from selinux.

copy-paste from @thaJeztah (#137 (comment)):

I also suggest to disable the "squash and merge" and "rebase and merge" options (mostly personal preference, as they clobber the contributor's commits, and with that, their GPG signing)

I agree.

We could try enabling the "auto merge" option that's in beta (merge after required checks complete)

Haven't tried that yet. The only potential downside I see is PR authors should be more careful about marking their PR as draft while they still work on them -- but that's really minor.

from selinux.

Haven't tried that yet. The only potential downside I see is PR authors should be more careful about marking their PR as draft while they still work on them -- but that's really minor.

The auto merge still requires a reviewer to click the "(auto)merge" button, but they can do so before CI completes. GitHub will then merge once all required checks pass.

One possible caveat is pressing the button after CI passed, but before a second reviewer LGTM'd. I think the "second review pending" also qualifies as "required check", so merge would happen directly once the reviewer approved the PR. Technically, that's correct, but could be surprising.

Still, I think it's a nice feature that may be worth a try (although; probably more useful on repositories with a long CI time, saving you the "wait for CI to pass, and come back to click "merge")

from selinux.

Sounds good 👍

from selinux.

Implemented. Let me know if there are some rough edges.

from selinux.