opencollective / opencollective Goto Github PK

We want to experiment quickly, so in many cases instead of hacking the backend, we can have someone manually do the work during the experiment. So, let's create the "Operator" route. It takes the payload from the frontend and sends an email to operator@.

Ex: Allow splitting a donation towards multiple collectives. Instead of building the backend and shuffling tables for something that may not stick around, let the frontend send the split of money for each collective in a payload to the Operator.

const payload = {
    userId: 89,
    donationAmount: 100,
    donationCurrency: USD,
    split: {
        WWCode_HQ: 20, 
        WWCode_Seattle: 70,
        OC: 5,
        fees: 5
    }
}

The Operator (one of us) will manually "Add funds" to the right collectives.

Specs

• Takes a payload and sends it to operator@
• The route should only require a valid applicationKey to work

When making a donation, we should allow the donor to say a few words about them.
E.g. "Developer at Awesome Agency", "Thanks for this awesome open source project!", "In memory of ...", "Go Women Who Code, you rock!", "Proud sponsor", ...

Characters limit should be 100 (so that there is room to add a URL and @mention in a tweet).

Because it is related to the collective, it should be stored in the UserGroups table that makes the relationship between a user and a collective.

On the Website Repo, we should add a new input field here https://github.com/OpenCollective/website/blob/master/frontend/src/components/PublicGroupSignup.js#L30

and adapt the UserGroups model on API https://github.com/OpenCollective/api/blob/master/app/models/UserGroup.js#L11

How should we call this new column? description?

It would be great if there was a hook to tweet a "thanks" to new sponsors or donors from the OpenCollective organization Twitter account.

(instead of tests/frontend/output)

This will make it easier to see where end to end tests fail.
See https://circleci.com/docs/build-artifacts/

We should do that on website and app repos.

When a collective is open and host has not connected their stripe account yet, there is an overlap of the box and the text in donation flow. https://cldup.com/YB4ZCux-ip.png

Backers of a collective should receive a sticker with the logo of the collective and the date of when they started supporting the collective.

Let's brainstorm a few ideas here.

In a collective, people have different roles and different titles.
For example, you could have core contributors, organizers, volunteers, contributors, staff, etc.

Per @asood123's point, we should make sure we that don't create too much complexity with this. So I think it will be good to have only 3-4 different "master roles", but then people can name them how they want and subdivide them in different "tiers".

For example, in an open source project there are core maintainers then a bunch of contributors who contribute at very different levels (some doing one pull request a year, others once a month, others once a week). Likewise, there are different backers. Some giving $1, others giving $500. We should design for that.

This could be achieved by adding a title column in the UserGroups table (which should eventually be renamed to UserCollectives)

E.g.:

• ADMIN: People who are the main organizers / leaders. They can pre-approve expenses, edit the page of the collective. Title could be "Core contributors", "Staff", "Organizers", "Founders", "Maintainers".
• MEMBER: People who contribute more casually to the collective. They could have a role (e.g. "Community manager", "Advisor"). They could be called "Contributor", "Member", "Staff member", "Team member", "Volunteer".
• BACKER: People / companies who contribute money, "supporters", "sponsors", "gold sponsors", ...
• FOLLOWER: Someone who just wants to follow the progress of a collective but doesn't contribute to it

We should keep the organization of a collective as flat as possible but we also need to design for providing people different levels of contribution for which they should be acknowledged accordingly.

Here could be a way to schematize this:

Note that the about column solves this issues as well: #9 (one-liner/bio for backers)

It would be good to have a small badge that companies can put in the footer of their website that says "Proud sponsor of Open Source", or "We are contributing to Open Source Collectives" (something along those lines), that would link to their company profile page on OpenCollective.

Keep track of how members arrive to the collectives. see #18 for more detail.

They could use some design love ❤️

On a meetup with a host without stripe but with PayPal, when clicking on "Pay With PayPal", it triggers a slack notification before the donation actually went through.

That said, it doesn't seem to record the donation in the DB, so it doesn't look like an urgent bug as I initially thought.

When manually adding funds, an unknown error appears but funds do pass. https://cldup.com/dCg0yVdwpG.png

Tried it on dockersf and it redirected to paypal fine. After I logged in and clicked approve, it landed me here: https://opencollective-prod-app.herokuapp.com/login?next=/groups/45/transactions/403/callback.

Need to update the callback url at a minimum. There's also a weird delay after you click "Donate with Paypal".

After making a donation through the platform, redirect/show somehow that they show up in the github repo.

As a result, when approving an expense, it doesn't get reimbursed.

WWCode is impacted by this bug.

As per #18 organize members in Contributors, Backers, Friends (free membership)

...while waiting for #returnToMerchant to appear. Relaunching build usually fixes issue. Race condition or overloaded Paypal API? What are possible solutions?

E.g:

• failed: https://circleci.com/gh/OpenCollective/api/1470
• rebuild passed: https://circleci.com/gh/OpenCollective/api/1471

[Approve Transaction] Test Suite
================================

...

Running:  connect host Paypal account
 ✔ Element <#loadLogin> was visible after 5072 milliseconds.
 ✔ Element <input#login_email> was visible after 1627 milliseconds.
 ✔ Element <input.button.primary.default> was visible after 50 milliseconds.
 ✖ Timed out while waiting for element <#returnToMerchant> to be present for 60000 milliseconds.  - expected "visible" but got: not found
...

Issue appears even when CircleCi parallelization is disabled and even when tests don't seem to be running at same time on different branches.

Currently, when you donate $100, stripe charges you $100 and fees come out of that. Depending on how much host takes, end collective gets around ~$87.

We want to let users pay more fees on top of their donation. User clicks on Donate $100. Dialog shows:

$100
+ $13 fees
= $113
Confirm

Implementation proposal

1. Backend: Add a boolean field on the collective feesOnTop
2. Frontend: Create a new dialog that shows the final amount with fees

• If flipped (initially only for the French movement with a French host, so no currency issues), we show the dialog above.
• When they click confirm, we pass $113 to Stripe and show the Stripe dialog. Two dialogs aren't ideal but it would be the easiest way to do it. Otherwise, we'd need to rebuild a credit card donation form.

Open questions

• Should we do one dialog or two?
• Find out exactly how much stripe will charge for a european credit card. We can also assume a flat 3% rate and eat the difference of 20 cents or so.

Pulling the info for the public page description of the info from the dropdown menu instead of the description so it reads 'food&beverage' and not ' Pizzas, beer, for meetup'

The cards have the current date as default. We should allow for the core contributors (not backers) of a collective to edit since when they contribute to their project.

Talked to Seye (@seyeojumu) about how long our tests take and he thought it shouldn't be this long.

Hoping he can look at our setup and give us any recs.

Actual runtime of last few test runs: https://www.dropbox.com/s/ym4iv6eyjicdwka/Screenshot%202016-04-26%2012.39.52.png?dl=0.

I just noticed that the backers/sponsors are not displayed with a retina image. IMO they should – looks more official / professional / in active care / you-name-it.

Yes. How can we do that? I guess we will have force the height in the HTML

Yep, force the height in the HTML. Otherwise, maybe some hacks using svg where the svg includes an img with the forced height. (so that the HTML we have to paste is more compact) Maybe there's other ways to do it

yeah I want to keep the html compact, but I also wanted to keep flexibility to improve the design without having to change the HTML

with a card design like on http://opencollective.com/mochajs (but probably more compact than that)

discussion in #mochajs between @xdamman and @dasilvacontin

Probably an issue with the API since it is also appearing as "approved" on the app.

Steps to reproduce:

Go to http://localhost:3000/testcollective/expenses/submit
Submit an expense then reject it in the app.

Images in thank you emails are broken now.This is probably due to the new design. cc / @xdamman @carlosascari

Open to discussion on this. ESlint rules

{
  "parser": "babel-eslint",
  "env": {
    "node": true
  },
  "rules": {
    // Disallow Unused Variables
    "no-unused-vars": 2,
    // require space before/after arrow function's arrow
    // https://github.com/eslint/eslint/blob/master/docs/rules/arrow-spacing.md
    "arrow-spacing": [2, { "before": true, "after": true }],
    // suggest using arrow functions as callbacks
    "prefer-arrow-callback": 2,
    // suggest using template literals instead of string concatenation
    // http://eslint.org/docs/rules/prefer-template
    "prefer-template": 2,
    // suggest using of const declaration for variables that are never modified after declared
    "prefer-const": 2,
    // disallow modifying variables that are declared using const
    "no-const-assign": 2,
  }
}

For buttons to not show in hosts collectives

We need to support rupees as a currency for WWCodeDelhi. Changed it in DB currency is INR.
Also, CSS needs to be changed to reflect new currency: https://en.wikipedia.org/wiki/Indian_rupee_sign#/media/File:Indian_Rupee_symbol.svg

Currently, we link to a user's avatar photo on Twitter or wherever we can find it. Let's copy it to s3 and link to our copy. That way it won't go empty when the other site changes it.

We should have an easy process to on board open source repositories.

Apply to create an open collective for your open source project.

We are slowly accepting new open collectives. Apply today to reserve your spot.

1. Connect your github account
2. Select the repository for which you'd like to create an open collective (your repo needs to have at least 100 stars)
3. Select the people who should be part of the collective (minimum 2)
4. What's your mission?
5. What would use the money for?
6. Thank you for your application. To be eligible, you need to have at least 10 people to commit to become a backer or a sponsor. They won't be charged until your collective is approved. Share with them this link: opencollective.com/org/repo

Pending collective

If a collective hasn't been approved yet, their page should say something along the lines of:

We have applied to become an open collective. To be approved, we need your help!

We need x more people to commit to become a backer or a sponsor.

Become a backer for $5/month
Become a sponsor for $100/month
You will only be charged once we reach our goal of 10 backers or sponsors

Thank you for your commitment. Help us spread the word!

Currently, we give 5% to the host for any donation. We need to customize this. Some hosts (like the self-hosted ones) want 0%. Some like WWCode want 10%.

This needs to be done soon to make fees for april easier.

They take forever and are unreliable. It is slowing us down.
Any expert in CircleCI out there who can give a helping hand?

It's not a trivial problem as we have a lot of tests spread out across different applications:

• API unit tests
• Website react unit test and server unit tests
• Website end-to-end tests using nightwatch (phantomjs)
• APP react unit tests
• APP end-to-end tests

When we test website or app, we should first checkout the api repository, install it and run it (ideally, we would want to find a way to cache that as it takes a lot of time).

After a donation, we should offer the user an easy way to share on Twitter and Facebook (and we should add ?referrerId=$userid to the URL of the collective). Both for first time donors and returning donors.

GitHub:

OpenCollective:

It's important to communicate to the different members of a collective.
To that end, we should make it easy to send an email update and target specifically certain tiers (e.g. an update for backers, an update for sponsors).

Since a collective is a collaborative space, any member should be able to submit an update (aka a post). For example to do a summary of the latest meetup, share pictures/videos, etc.

To avoid spam, an admin of the collective should approve the post for it to be sent out by email to the targeted audience.

We would love to support multiple languages.

It looks like the best framework to do this is to use this React library https://github.com/yahoo/react-intl

We should use the upcoming v2 (currently in release candidate 1), as it brings a lot of changes that will be difficult to migrate to if we already start with v1.

Right now, we did a very quick hack to make OpenCollective in French for LaPrimaire.org, see

• Website: https://github.com/OpenCollective/website/pull/120
• API: https://github.com/OpenCollective/api/pull/261

This should also remove the need to use Numbro https://github.com/OpenCollective/website/blob/master/frontend/src/lib/format_currency.js

We have an Activity model that's meant to record every action in the system. It started as a way to show an activity feed on a group page. Then it evolved into recording events to show in slack. It's incomplete in both cases.

We need to record everything that happens in the system - every action, every bit of data that comes in. Activity should be modified to cover all the cases.

One way to do this would be to create a middleware that intercepts all routes and records everything. This would clean up scattered Activity entries everywhere and put them in one place for easy maintenance. Open to other ideas like Kafka?

We should let hosts know on a regular basis when their collectives are receiving donations to make their management easier and more efficient. I suggest hosts can opt-in between every activity/daily digest/weekly digest. I wouldn't offer monthly since they get the monthly email anyway.

Allow for Collective organizer/core contributor to approve expenses as well as the host.
Eventually we could allow for collectives to choose between joint approval (host & organizer) or either/or approval.

Eventbrite allows organizers to ask ticket buyers to pay the platform fees. We should do the same.

host of WWCodeDC is trying to manually add funds to the collective and they are getting an error that says 'CreatedAt must be less than or equal to "Tue Apr 12 2016 17:00 GMT-7 PDT" idem for a different date.

I can repro it on any collective, just try to edit it.

We require all expenses to have a receipt attached. Currently, users need to manually fill that info. No one likes filing expenses, so any reduction in friction in this process would go a long way.

We want to OCR receipts and prefill some of the fields like here: https://opencollective.com/yeoman/expense/new. Submit a receipt and whatever fields we can deduce, we will fill the form for user to review.

Fancier versions of this could hook it up to a phone number. Txt a receipt to us and we'll send you back a link showing what we prefilled and you can edit or approve.

All expenses: https://staging.opencollective.com/ispcwa/expenses
All donations: https://staging.opencollective.com/ispcwa/donations

Filing new expense: https://opencollective.com/yeoman/expenses/new

From user Hunter Trujillo

Hey, I just tried donating, and after Stripe payment went through, I got an error in the title bar that said this:
Unexpected token < in JSON at position 0
And then in my console, I'm guessing you're using Redux, the action that failed was this:
DONATE_GROUP_FAILURE
There was a 503 from a request at this endpoint:
https://opencollective.com/api/groups/43/payments/
The page I was on was here:
https://opencollective.com/apex#support

User had changed ZipCode recently. No place in stripe path to change zipcode

Possible fixes:

• enable the zip code field on the stripe form
• disable declining cards that fail zip code verification on your stripe settings.

Donation ID 337: $200 to WWC Austin (group id2), platform fees $10 (ok) but host fees is $10 as well (should be $20, 10%) I checked the group and host fees says 10, so I'm not sure what the issue is.

La Primaire: txn id: 327 host fee 25, id 400 host fee 0 (I'm sure this is because we modified fees in between) I'm manually calculating collective's net.

Les barbars: txn id359: host fees should be 0, it is calculating 5%. (might be same issue as above, check next month)

Vloupe [bug]: It started calculating 5% for host on 4-18 (txn 364), but host fee was 0 before and it still says 0.

For paypal flow we need to differentiate fees 'manual' and 'paypal' since 'manual' don't have paypal fees. But we should report them anyway in the monthly email. Since this is still manual, it's a pain to calculate because I can't aggregate expenses and # of expenses.

If PayoutMethod is empty, I assume it's manual. Please confirm.

For foreign currencies we need to pull from Stripe the platform fees and host fees in USD at the currency exchange rate of the day. Otherwise we can't calculate revenue properly.

• login / logout is not working https://cldup.com/eV_5SaBaZM.png & https://cldup.com/r7xipqu0N9.png
• the tier name is pulled from the 'name' and not the 'title'
• force min/max height for tier 'button'
• make "we are on a mission to" bigger
• add "..." to the beginning of the mission statement & remove final "."
• do we still need short description & long description now that we have mission statement? seems redundant.
• when a user changes twitter avatar the avatar in public page keeps loading see https://cldup.com/HvFHyzJu7Y.png
• force heights in donation boxes see: https://cldup.com/hv21KSO0oi.png
• a "see all donations" button seems to be missing. Maybe all buttons in this area should be the same size? https://cldup.com/GxUKGYPmhy.png
• currency in presets amount is Euro currency in other is USD https://cldup.com/8CSE9CEoQd.png
• fix centered text & bullet points https://cldup.com/JOCzBk8S_2.png
• the images that are pulled from the db are not forced to fit the designated space in the public page so some of them look cut off in. See for example: https://opencollective.com/perthindymedia#why-join