bug in addReaction() function about cobratoolbox HOT 8 CLOSED

model.rev should be depreciated in the next month

from cobratoolbox.

Hi,

Why don't you make this change in your repo and create a pull request? If you don't want to, I don't mind putting one up.

Thanks,
Srikiran

from cobratoolbox.

If you don't mind doing it, that'd be great. I'm still quite new to GitHub
and am learning how to do such things...

Thanks,
James

On Thu, Jul 17, 2014 at 10:03 AM, sriki18 [email protected] wrote:

Hi,

Why don't you make this change in your repo and create a pull request? If
you don't want to, I don't mind putting one up.

Thanks,
Srikiran

—
Reply to this email directly or view it on GitHub
#19 (comment)
.

from cobratoolbox.

model.rev will be depreciated

from cobratoolbox.

Nice. I had issues with reversibility in cobrapy and wanted to make sure
our solutions were consistent. Rev really is redundant information. In
cobrapy it is now a computed property.

On Friday, January 30, 2015, Ronan M.T. Fleming [email protected]
wrote:

model.rev will be depreciated

—
Reply to this email directly or view it on GitHub
#19 (comment)
.

from cobratoolbox.

@rmtfleming , how shall we proceed with this? Thanks.

from cobratoolbox.

While not yet completely removed from all parts, rev is deprecated now, and most functions are updated to extract rev from model.lb < 0. The concrete issue named is solved so this can be closed.

from cobratoolbox.

Nice! Thanks @tpfau ⚽️

from cobratoolbox.