Output WAV still seems to have problems if there's loop header section about deretore HOT 5 OPEN

I see "unknown chunk" after PCM sample data. I don't know what it is, but it doesn't seem to disturb anything...

from deretore.

Ah, the same bug I had once created & then fixed😂

segfault-bilibili/hca.js@3804499

Oh, I need to confirm this... Confirmed.

from deretore.

At least the "seam" block (at the start of looped blocks) itself should be re-decoded. I'm not sure whether more blocks should be re-decoded, however the affected bytes don't seem to be enough to make a full block - in other words, reworking one block seems to be enough to make the output byte-to-byte exactly the same to "stupidly" decoding every block including looped ones.

Oh, I need to confirm this... Confirmed.

from deretore.

Still not sure what happend, but something must be wrong - I tested with an HCA with its loop section stripped, and then the output WAV file seemed to be normal this time, without weird "unknown" chunk at the end.

What makes this an issue is, this seems to be caused by dozens of zero bytes inserted in the middle of PCM data...

The WAV header part is the same - which means the offset/size value written to the header is correct, then probably the writing offset(s) is miscalculated. See updates in the top post.

from deretore.

Oh now we have two bugs😂

from deretore.