Code in setting conteroller

https://github.com/opencart/opencart-3/blob/main/upload/admin/controller/setting/setting.php#L258-L262

Missing from twig
https://github.com/opencart/opencart-3/blob/main/upload/admin/view/template/setting/setting.twig

But is added in customer_form
https://github.com/opencart/opencart-3/blob/main/upload/admin/view/template/customer/customer_form.twig#L101

When you register directly from affiliate/register in database is added only as Customer.

Should not require PHP 8. should be put back to 5.4 or create new version of open cart.

Missing ` after table name review

Error with
PHP Warning: Undefined array key "trial_remaining" in E:\Ampps\www\3xx\system\library\cart\cart.php on line 230

I have recently intalled OC 3.0.3.8 via Maintenance branch to work with PHP 8.1.

As I'm starting to setup my store, I put it in maintenance mode the local and online stores but, the maintenance mode page/message isn't working. My store remains with the normal navigation.

Here I setup de maintenance mode:

Here is the online and local store without any message:

Because Klarna library is deprecated this payment should be removed.

Just a reminder :)

Missing subscription controller from catalog/account

https://github.com/opencart/opencart/blob/master/upload/catalog/controller/account/subscription.php

Why you have reverted class for cookie buttons?

More nice this way...

In the table is address_format text NOT NULL, (oc_country)

Account link
/index.php?route=account/subscription
The show error
PHP Unknown: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /system/engine/action.php on line 61

With SMTP enabled

ArgumentCountError: Too few arguments to function Mail\Smtp::__construct(), 0 passed in system\library\mail.php on line 35 and exactly 1 expected in system\library\mail\smtp.php on line 20

line 140 is this

$config_captcha_page = json_decode((array)$config->get('config_captcha_page'), true);

Code need to be downgraded for bootstrap 3
https://github.com/opencart/opencart-3/blob/main/upload/catalog/view/javascript/common.js#L365

Both functions: aprove and deny doesn't have a page redirect

https://github.com/opencart/opencart-3/blob/main/upload/admin/controller/customer/customer_approval.php#L179

$this->response->setOutput...

Cookie popup need to be fixed
https://github.com/opencart/opencart-3/blob/main/upload/catalog/language/en-gb/common/cookie.php#L4

2022-10-12 07:26:22 - Error: Call to undefined method Cart\Tax::unsetRates() in catalog\controller\extension\total\shipping.php on line 71

With PHP 8.1 catalog side.

Admin side work just fine

After you fill all the info from Your Personal Details, Continue button doesn't work.

No console logs, no popup error..

    Error when add to cart with product has subscription.

SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data
OK
<b>Warning</b>: Undefined array key "date_next" in <b>/system/library/cart/cart.php</b> on line <b>236

Originally posted by @opencartcomvn in #131 (comment)

Hi,
Please check why both Recurring and Subscriptions?

sudo apt install rename

find . -exec rename 's/recurring/subscription_plan/' {} ";"

find ./ -type f -readable -writable -exec sed -i "s/Recurring/SubscriptionPlan/g" {} \;

find ./ -type f -readable -writable -exec sed -i "s/recurring/subscription_plan/g" {} \;

After a fresh installation and the first login to admin you'll be promted to move your storage folder.

When clicking on apply, the config.php will be changed and an empty folder will be created. However, the files from system/storage won't be moved and the shop is broken.

Warning: require_once(C:/xampp/storage/vendor/symfony/polyfill-ctype/bootstrap.php): Failed to open stream: No such file or directory in C:\xampp\htdocs\system\vendor.php on line 19

Fatal error: Uncaught Error: Failed opening required 'C:/xampp/storage/vendor/symfony/polyfill-ctype/bootstrap.php' (include_path='C:\xampp\php\PEAR') in C:\xampp\htdocs\system\vendor.php:19 Stack trace: #0 C:\xampp\htdocs\system\framework.php(5): require_once() #1 C:\xampp\htdocs\system\startup.php(107): require_once('C:\\xampp\\htdocs...') #2 C:\xampp\htdocs\admin\index.php(19): start('admin') #3 {main} thrown in C:\xampp\htdocs\system\vendor.php on line 19

Model name should be updated....also possible need to updated more code

https://github.com/opencart/opencart-3/blob/main/upload/admin/controller/catalog/product.php#L703 as per master branch

https://github.com/opencart/opencart/blob/master/upload/admin/controller/catalog/product.php#L901-L910

TypeError: ControllerExtensionAdvertiseGoogle::before_checkout_success(): Argument #2 ($data) must be of type array, null given, called in system\storage\modification\system\engine\action.php on line 75 in catalog\controller\extension\advertise\google.php on line 41

Hi,
Please check
Cannot install with your latest commit

In both the footer and the account panel the links go to account/affiliate. However this controller has no index function which results in an issue in routing:

TypeError: Cannot assign null to property Router::$error of type object in /home/webpages/lima-city/marvinkleinmusic/opencart/system/engine/router.php on line 75

For example:
https://opencart.marvinkleinmusic.de/index.php?route=account/affiliate&customer_token=ZYtncbCKYLgQZ82k5c4zi75Qor

In the account panel it should either redirect to account/affiliate/add or account/affiliate/edit

In the footer it should link to affliate/login

Otherwise nobody can signup for the affiliate program.

Hi
private array $error = [];
syntax error unexpected T_ARRAY unexpected T_FUNCTION or T_CONST
https://www.php.net/manual/en/tokens.php
Older
private $error = array();
So removing the array keyword and just leave it like:
private $error = [];

A bunch of javascript error and you can't upgrade

Just a short question: why is there no release published?

Reason why I ask: more and more people are asking for a php 8.x compatible OpenCart 3.0.3.8
And find at least this repo, but without any release it may be hard to install.
Or at least - if no releases will be published, publish a short description for those, are not firm with Github.

And state in the readme that this repo IS compatible with php 8.x (8.1.x).
And an official fork of the original.

Affected version 3.0.3.7
(maybe exist on lower versions)

File (original)
in catalog\model\checkout\order.php
line 4
insert query 3 times account, shipping payment
looks like this

..custom_field = '" . $this->db->escape(isset($data['custom_field']) ? json_encode($data['custom_field']) : '') . "',...
Wrong!

this is the right way
...custom_field = '" . (isset($data['custom_field']) ? $this->db->escape(json_encode($data['custom_field']) : '')) . "',...

Like chars like éáűőúöüóí it save to DB like u00e9u00e1u0151
without slash and json_encode cant' translate it back.

Opencart version 3.0.3.9
Default Theme

Operating System
CentOS v7.9.2009

Server type: MySQL
Server version: 5.7.41

PHP Version ea-php81

Installing a extension from opencart marketplace "PDF Invoice Pro For Orders" https://www.opencart.com/index.php?route=marketplace/extension/info&extension_id=22647&filter_search=PDF%20Invoice%20Pro%20For%20Orders
Installed the extension via Extension Installer the message was showing successful but Extension/extension> Module doesn't show any extension to installed.

Same happened with other extension Atome payment.

Only the OCMOD file shows up in modifications.

If a customer has 2 custom_fields: one is for Account (named custom_field_account) second is for Affiliate (named custom_field_affiliate)
When customer is edited and both custom_fields are filled in with values, these values are inserted together in database in both tables.

customer table
customer_affiliate table
When custom_field_account value should be inserted only in customer table and custom_field_affiliate value should be inserted only in customer_affiliate table.

Or I think is much better to change admin affiliate structure like in 4.0 Marketing->Affiliate

admin load if you change this line

$this->registry->set('googleshopping', new \Googleshopping($this->registry, $store_id));

to

$this->registry->set('googleshopping', new Googleshopping($this->registry, $store_id));

from
https://github.com/opencart/opencart-3/blob/main/upload/system/library/googleshopping/traits/libraryloader.php#L8

Possible session bug
https://github.com/opencart/opencart-3/blob/main/upload/catalog/controller/startup/session.php#L29

Work if you change that line to 'expires' => 0, ,but I don't know if is a good solution

Hello, if I select mail from settings->store->mail, not sending email to customer for new order confirmation. If I try to set smtp, not working (page show alert "error" and connection refused in logs). But server config is right because working with same parameters in Windows Mail Client!! I have try ssl:// and tls://, provider instructions says port 465 for smtp server. Also I try without suffix with no luck. I want only send email confirmation to customer when new order success!

index.php?route=checkout/checkout

Notice: Undefined property: Proxy::getExtensionsByType in \system\engine\loader.php on line 243
#########################################
PHP Unknown: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in \system\engine\action.php on line 61
#########################################
Exception: Error: Could not load model catalog/subscription!
admin/index.php?route=catalog/product/edit
admin\controller\catalog\product.php
Line 700
// Subscription
$this->load->model('catalog/subscription');

    $data['subscriptions'] = $this->model_catalog_subscriptions->getSubscriptions();

##########################################
Warning: You do not have permission to modify subscription plans!
admin\controller\catalog\subscription_plan.php
Line 472
protected function validateForm() {
if (!$this->user->hasPermission('modify', 'catalog/subscription')) {
$this->error['warning'] = $this->language->get('error_permission');
}

##########################################
Notice: Undefined property: Proxy::addSubscription in
##########################################

Hi,
system/library/document.php
Oder version can add script and style to header and footer from controller

$this->document->addScript('catalog/view/javascript/jquery/magnific/jquery.magnific-popup.min.js', 'header');
$this->document->addStyle('catalog/view/javascript/jquery/magnific/magnific-popup.css', 'footer');

But not work with this version and MB

[<b>Warning</b>: Array to string conversion in]

Please check

how to combine duplicate custom_field name with value opencart version 3038?
admin=>order info=>Account Custom Fields
before combination:
Account Custom Fields
color yellow
color green
color red
image 3ba9557e23ecb68b0152683e2623dd72907bdfff
image MPX2102AP.jpg
size big
size small
after combination, the chart will show like:
Account Custom Fields
color: yellow,green,red
image: 3ba9557e23ecb68b0152683e2623dd72907bdfff, MPX2102AP.jpg
size: big, small
how to do it?

What version of OpenCart are you reporting this for?

3.0.3.8

Describe the bug
There is 5 steps of edit order: on first one change currency, on step 2 you see product(s) with correct new currency and on final step 5 is all visible in new currency (no problem) but clicking save opencart confirm saving on green background but email comes with previous currency, in databse there are not updated columns: currency_id, currency_code, currency_value.

To Reproduce

Go to any order and choose edit ( I did fresh install of 3.0.3.8 made one order in default USD and tried to change that into EUR)
on Step 1 change currency into whatever (EUR on my case)
Save on step 5
See error - no error, but return to that order, still in previous currency
Expected behavior
order in new currency

Server / Test environment (please complete the following information):

Local development? Deployed to a web server? - local docker + web server
Operating system - linux
PHP version - 7.3.32
Apache version - 2.4.51 debian
Browser(s) tested with [e.g. chrome, safari - if applicable] - opera, chrome, edge
Additional context
in the API edit function in catalog/controller/api/order.php and model_checkout_order->editOrder there is nothing that sets the currency when updating an order.

What is this?

https://github.com/opencart/opencart-3/blob/main/upload/admin/view/template/setting/setting.twig#L829

Why not do a 3.0.3.9 release.

https://www.opencart.com/index.php?route=cms/download/history

Fatal error: Uncaught TypeError:

Argument 1 passed to Session\File::__construct() must be an instance of Session\Registry, instance of Registry given, called in system\library\session.php on line 29 and defined in system\library\session\file.php:4

Stack trace:

0 system\library\session.php(29): Session\File->__construct(Object(Registry))
1 system\framework.php(88): Session->__construct('file', Object(Registry))
2 system\startup.php(104): require_once('...')
3 install\index.php(37): start('install')
4 {main} thrown in system\library\session\file.php on line 4

When update order address, if use combobox for select order I have this. Checked on 2 differents installations of Opencart 3.0.3.8 See attachments

Undefined array key "extension" in
catalog/model/checkout/payment_method.php on line 12
catalog/model/checkout/shipping_method.php on line 12

ArgumentCountError: Too few arguments to function getMethod(),

HI.
upgrading a current staging installation from 3.0.3.6 to 3.0.3.8 I found the following errors
Steps to reproduce:
Navigated to the folder installation.

1. Run composer update
2. <store.local>/install
3. Finish installation (many errors encounter with the current opencart.sql ) I had to adjust this manually (push request on the way)
4. Navigate to the store and /admin area
5. Errors:
6. PHP Unknown: preg_match(): Passing null to parameter #4 ($flags) of type int is deprecated in /home/user/storage/vendor/scssphp/scssphp/src/Parser.php on line 1151
7. PHP Unknown: preg_match(): Passing null to parameter #4 ($flags) of type int is deprecated in/home/user/storage/vendor/scssphp/scssphp/src/Parser.php on line 1232
8. Automatic conversion of false to array is deprecated in /home/user/storage/modification/catalog/controller/startup/startup.php on line 115
9. PHP Unknown: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /home/user/storage/modification/catalog/controller/startup/seo_url.php on line 60
10. PHP Unknown: Return type of Twig\Markup::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/user/storage/vendor/twig/twig/src/Markup.php on line 35
11. PHP Unknown: Return type of Twig\Markup::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/user/storage/vendor/twig/twig/src/Markup.php on line 40