OTLP/HTTP gzip Content-Encoding support about opentelemetry-erlang HOT 2 CLOSED

Great!

I think it should be applicable to both http_protobuf and http_json. And grpc, but there it should just be an option to pass to grpcbox.

Your configuration looks good. Hm, though actually it should be compression: gzip, that way it can add support for additional compression algorithms in the future if needed.

Code looks good too.

from opentelemetry-erlang.

Hey, I'm interested to work on this. I have take a brief look into it and have a few questions in my mind before sending in a PR:

• Is this only applicable to http_protobuf protocol?
• What would be the approach for user to configure it? Similar to otlp_endpoint? Something like this?

config :opentelemetry, :processors,
  otel_batch_processor: %{
    exporter: {:opentelemetry_exporter, %{
                                          gzip: true,
                                          endpoints: ["http://localhost:9090"],
                                          headers: [{"x-honeycomb-dataset", "experiments"}]}}
  }

• What are the approach of writing a test for this?

Here's a rough implementation I have in mind on opentelemetry_exporter.erl:

export(Tab, Resource, #state{protocol=http_protobuf,
    %% ... other code
    CompressedProto = zlib:gzip(Proto),
    case httpc:request(post, {Address, [{"content-encoding", "gzip"} | Headers], "application/x-protobuf", CompressedProto}, [], []) of
    %% ... other code

Am I heading towards a right direction here? If so, for the option to configure gzip:

• do we save it as part of the state?
• or do we get it on runtime, before we make the HTTP request?

from opentelemetry-erlang.