Code Monkey home page Code Monkey logo

Comments (6)

jvilhuber avatar jvilhuber commented on May 26, 2024

I found a similar (same?) bug in the nginx module: #27
Perhaps this just needs a bump to the latest opentelemetry-cpp library?

from opentelemetry-cpp-contrib.

jvilhuber avatar jvilhuber commented on May 26, 2024

@TomRoSystems Any chance you could update the library to something recent to see if this fixes some of the issues I've had? I suspect #78 is also related to this.

from opentelemetry-cpp-contrib.

jvilhuber avatar jvilhuber commented on May 26, 2024

@TomRoSystems Any update on this one?

from opentelemetry-cpp-contrib.

jvilhuber avatar jvilhuber commented on May 26, 2024

FWIW I did a local test upgrading to opentelemetry-cpp-1.0.0-rc1 (the latest version that builds without Api changes) and it seems to fix the problem. So I'm pretty sure just upgrading the opentelemetry-cpp library will do the trick here. I got stuck on adding a default service.name, however, and since cpp isn't my language, I'm not sure any PR of mine would be good enough (though I'm happy to share what little I did i.e. hacked up).

from opentelemetry-cpp-contrib.

TomRoSystems avatar TomRoSystems commented on May 26, 2024

Are you building with Bazel or CMake? As I think CMake was already using version you mentioned -
setup-cmake.sh line 62

from opentelemetry-cpp-contrib.

jvilhuber avatar jvilhuber commented on May 26, 2024

I was using bazel, but cmake seems faster, so I can use that instead. Any chance you can upgrade to the latest opentelemetry (1.1.0 I think)?
EDIT: How are the assets under https://github.com/open-telemetry/opentelemetry-cpp-contrib/releases built? bazel or cmake?

from opentelemetry-cpp-contrib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.