Comments (1)
kyungeunni
commented on September 25, 2024
+1 on this issue.
otel-webserver-module Nginx instrumentation doesn't add required attributes according to HTTP semantic conventions, at least for HTTP Client span.
To give you a concrete example, I instrumented nginx app using the steps mentioned in this [blog]. I noticed a Span named ngx_http_otel_mirror_handler_ which seems to proxy a request. The only attribute it contain is interactionType: Str(EXIT_CALL). This Span is an HTTP Client span and I expect to see it contains required attributes.
Here's the example from the collector:
2024-04-03 13:42:15 Span #10
2024-04-03 13:42:15 Trace ID : 5d63285f0ac981b795de11849eb46803
2024-04-03 13:42:15 Parent ID : 454268c37f58c99e
2024-04-03 13:42:15 ID : cf87334511ce3de3
2024-04-03 13:42:15 Name : ngx_http_otel_mirror_handler_
2024-04-03 13:42:15 Kind : Client
2024-04-03 13:42:15 Start time : 2024-04-03 04:42:10.916024295 +0000 UTC
2024-04-03 13:42:15 End time : 2024-04-03 04:42:10.916064337 +0000 UTC
2024-04-03 13:42:15 Status code : Ok
2024-04-03 13:42:15 Status message :
2024-04-03 13:42:15 Attributes:
2024-04-03 13:42:15 -> interactionType: Str(EXIT_CALL)
from opentelemetry-cpp-contrib.
Related Issues (20)
- [CI] Add CI for instrumentation/spdlog
- [RELEASE] Prepare release for opentelemetry-cpp-contrib 1.15.0
- [CI] Upgrade Prometheus CI to opentelemetry-cpp 1.15.0
- [CI] Upgrade otel-webserver-module CI to opentelemetry-cpp 1.15.0 HOT 1
- Upgrade otel-webserver module for nginx stable version 1.26 and mainline 1.25.5 HOT 1
- Release webserver/v1.1.0 is broken HOT 1
- [BUILD] boost_log compilation error (possibly dangling reference) HOT 2
- Support for legacy Cloud Trace propagation header HOT 1
- Nginx instrumentation generate multi propogation header when request header count >= 20 HOT 1
- Use correct type for severity_logger
- NginxModuleTraceAsError` directive not working as expected in ngx_http_opentelemetry_module HOT 3
- NginxModuleRequestHeaders and NginxModuleResponseHeaders are case sensitives
- nginx span shorter than upstream server span
- Centos7 build failing due to centos7 EOL HOT 1
- Update otel-webserver-module for almalinux 9, since centos7 is EOL HOT 2
- opentelemetry-cpp v1.16.0 deprecates API methods currently in use
- Support nginx 1.27.0
- Support NGINX 1.26.1 (stable) and 1.27.0 (Main)
- `b3` propagator not working when internal redirect
- Nginx instrumented with CPP otel contrib rejects requests without User-Agent field.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-cpp-contrib.