open-spaced-repetition / fsrs-browser Goto Github PK

https://github.com/open-spaced-repetition/fsrs-rs/blob/16bdf86c5053038dd6fc9bf939f395b889be9fe2/src/convertor_tests.rs#L178-L190

@AlexErrant, this function is used by fsrs-browser. It causes some problems for people in other timezone.

The file for reproduction: revlog_martin.csv

I am unable to run the training and found that this piece of code is causing the issue.

AlexErrant/burn@3db5c11...48042af#diff-6a35a98c03bc063fbb33e367f90ce1f477a9b10fc9508313986c7706c7558e17

- wasm-bindgen-rayon = { version = "1.0.3", optional = true, features = [
-   "no-bundler",
- ] }

+ wasm-bindgen-rayon = { version = "1.0.3", optional = true } 

After rolling back this code, I discovered that I can run the training normally.

https://github.com/AlexErrant/fsrs-browser/blob/25ab2530f0ca6a2e2847ccb90d52c283f15dd75f/src/lib.rs#L27-L44

Here is my code:

https://github.com/L-M-Sherlock/fsrs-wasm/blob/15a98f7657ca586337c7167f181e6a3dda7308aa/src/lib.rs#L50-L76

We can build the FSRSItem directly.

After completing the training, I used progress.free(), but I encountered the error Uncaught Error: null pointer passed to rust. Even when I used setTimeout(() => progress.free(), 1000), the error still occurred.

Does this mean that I don't need to free the progress ?

Would you like to release a npm package or something else? Or build an application based on fsrs-browser?

run sandbox example, i get:

Did you stick into any problems?

The FSRS-rs provided progress in compute_parameters:

https://github.com/open-spaced-repetition/fsrs-rs/blob/5cd2d8d965a4f20cb9bd5dc6395aa82c7445ffe8/src/training.rs#L202

Anki uses it to display progress of training:

https://github.com/ankitects/anki/blob/15506328e95ed853364759099123c94c7567d214/rslib/src/scheduler/fsrs/weights.rs#L78-L99

But I don't know whether it is possible to export the progress to js.

@asukaminato0721, @AlexErrant, @ishiko732, what do you think of it?

git clone https://github.com/open-spaced-repetition/fsrs-browser
cd fsrs-browser
git submodule update --init --recursive
./prod.sh
hanging Installing wasm-bindgen...