Comments (7)
BekahHW
commented on May 31, 2024
1
@safaanilatasoy there isn't currently a Pull Request (PR) there because it was close with comment: #246 (comment)
Take a look at that and let us know if you have any questions.
from guestbook.
safaanilatasoy
commented on May 31, 2024
.take
from guestbook.
BekahHW
commented on May 31, 2024
Hey @safaanilatasoy just wanted to check-in and see how this is going.
from guestbook.
safaanilatasoy
commented on May 31, 2024
Hi @BekahHW, everthing is good but I sent a pull request, I didn't fully understand what else I need to do.
from guestbook.
adiati98
commented on May 31, 2024
Hey @safaanilatasoy,
I've closed your PR and explain the reasons in the comment there. Please read the comment.
That been said, you need to create 2 new branches:
- To work on changes for this issue.
- To add yourself to the guestbook.
Once you're done with one thing, create a new pull request. Then, work on the next. And don't forget to complete the PR form. Incomplete PR form will be marked as invalid and may be closed.
Feel free to ask questions if you need clarifications. Thanks! :)
from guestbook.
safaanilatasoy
commented on May 31, 2024
@adiati98 Hello, ready for review 🚀 I hope it happened this time 😄 thank you
from guestbook.
adiati98
commented on May 31, 2024
@safaanilatasoy I left reviews on your PR. Don't hesitate to let me know if you have questions or need any help. 😊
from guestbook.
Related Issues (20)
- docs: Add screenshot requirement to PR template
- docs: Make adjustments to`CONTRIBUTING.md`
- docs: more adjustments to the PR template HOT 7
- docs: more adjustments needed in `Contributing.md` file
- Docs: Create an issue template to add users as contributors HOT 1
- Docs: Remove "Adding a New Section to the Documentation" section HOT 2
- Docs: Remove the "Running the Project Locally" from Contributing Guide HOT 2
- Docs: Adjust wording in the Contributing Guide HOT 3
- Feature: Clarification needed in Translation Guide HOT 3
- docs: Clarity about screenshot HOT 4
- Feature: Add @JulesRules65 as a contributor HOT 2
- Feature: add @chrisVCH as a contributor HOT 2
- Feature: Issue for commits pushed to main branch
- Bug: CODEOWNERS does not automatically add reviewers
- Docs: Update pull request template HOT 3
- Bug: issue template for guestbook is not listed
- Feature: adding contributor
- Feature: add @skippharaoh as a contributor
- Feature:add @Woytsekj as a contributor
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from guestbook.