docs: more adjustments to the PR template about guestbook HOT 7 CLOSED

Yeah, @adiati98, I think we should add the issue thing to the intro course. It's a good way to get contributors into a better flow of contributing.

from guestbook.

@BekahHW, what do you think? Same to you @adiati98.

from guestbook.

@CBID2 when would 1. be not applicable?
I wonder if we need the documentation section at all. What might be more effective is after the getting started section having a question like:

How have you contributed to this repository?

• Updated documentation (You're finished with the PR template!)
• Added myself as a contributor (move on the the next section)

3. Yes!!!

from guestbook.

@CBID2 when would 1. be not applicable?

I wonder if we need the documentation section at all. What might be more effective is after the getting started section having a question like:

How have you contributed to this repository?

• Updated documentation (You're finished with the PR template!)

• Added myself as a contributor (move on the the next section)

3. Yes!!!

@BekahHW, 1 would be if contributors aren't adding their name to the guestbook. Like fixing a bug or updating other aspects of the repo(e.g. docs and adding features), but what you came up with is more effective.

from guestbook.

@CBID2

• I quite agree with @BekahHW not to have "What type of PR is this?" section (and maybe also "Added to documentation?" section).

  I might be wrong, but I think making the PR template focus on adding contributors to the guestbook is more effective here.
  This repo is rarely receiving documentation updates except from maintainers. For that purpose, we can always adjust the PR templates ourselves if necessary (like add link PR to the related issue, etc.) or create one from scratch.

• 3. Put a ## Closes Issue section after the What Type of PR is this? section

  We can always add this one although we usually creates issue only to update docs.

  In general, this repo doesn't require issue to add contributors. Except if we want to update the Contributing Guide and apply the suggestion for contributors to learn and practice how to create an issue and link it to the PR. Do we want to do this?

from guestbook.

@CBID2

• I quite agree with @BekahHW not to have "What type of PR is this?" section (and maybe also "Added to documentation?" section).

  I might be wrong, but I think making the PR template focus on adding contributors to the guestbook is more effective here.

  This repo is rarely receiving documentation updates except from maintainers. For that purpose, we can always adjust the PR templates ourselves if necessary (like add link PR to the related issue, etc.) or create one from scratch.

• 3. Put a ## Closes Issue section after the What Type of PR is this? section

  We can always add this one although we usually creates issue only to update docs.

  In general, this repo doesn't require issue to add contributors. Except if we want to update the Contributing Guide and apply the suggestion for contributors to learn and practice how to create an issue and link it to the PR. Do we want to do this?

Good point @adiati98! :) Doing this would be a great way to practice.

from guestbook.

@BekahHW I'll create an issue and work on this. 👍

from guestbook.