open-o11y / opentelemetry-collector-o11y Goto Github PK

The cortex exporterexporter intends to import and use the Prometheus remote write exporter from upstream; However, since the Prometheus remote write exporter has not been fully merged upstream, the OpenTelemtry Collector code has been copied to /internal folder of this project, and a replace directive in go.mod redirects imports of go.opentelemtry.io/collector to /internal/opentelemtry-collector. Once upstream code is fully merged and stable, the Collector code and the replace directive in this project can be removed.

When the collector support translates OpenCensus metrics to internal metrics, it doesn’t set the Temporality of OTLP metric, so the OTLP metric gets a INVALID Temporality; The Prometheus remote write exporter checks temporality and only processes CUMULATIVE temporality metric. I bypassed that validateMetric test on my local setup, and the Prometheus remote write exporter was able to export metrics.

Temporality translation could be added here:
https://github.com/open-telemetry/opentelemetry-collector/blob/aeb604f4a3227415ba6e209363fcaf7d93817b70/translator/internaldata/oc_to_metrics.go#L154

To be filed

open-telemetry/opentelemetry-collector#1702