open-draft / until Goto Github PK

Contributors

Stargazers

Forkers

craig-davis cliffordfajardo nick-w-nick admmasters mattcosta7 mohamedwagih stewones singhamandeep007

// Original implementation  
export const until = async <DataType = unknown, ErrorType = Error>(promise: () => Promise<DataType>): Promise<[ErrorType, DataType]> => {
  try {
    const data = await promise()
    return [null, data]
  } catch (error) {
    return [error, null]
}
// Current implementation 
export const until = async <DataType = unknown, ErrorType = Error>(promise: () => Promise<DataType>): Promise<[ErrorType, DataType]> => {
  try {
   const data = await promise().catch((error) => { // .catch added
      throw error
    })
    return [null, data]
  } catch (error) {
    return [error, null]
}

export const until = async <DataType = unknown, ErrorType = Error>(promise: () => Promise<DataType>): Promise<[ErrorType, DataType]> => {
  try {
    const data = await promise().catch((error) => {
      throw error
    })
    return [null, data] // 💥 Type 'null' is not assignable to type 'ErrorType'.
  } catch (error) {
    return [error, null] // 💥 Type 'null' is not assignable to type 'DataType'.
  }
}

const [error, user] = await until(() => fetchUser(id))

const [error, user] = await until(fetchUser(id))

const [{status, value}] = await Promise.allSettled([fetchUser(id)])

{ status: "fulfilled", value: user } // or
{ status: "rejected",  reason: Error('an error') }

-  const [error, user] = await until(() => fetchUser(id))
-
-  if (error) {
-    return handleError(error)
-  }

+  const [{status, value: user}] = await Promise.allSettled([fetchUser(id)])
+
+  if (status === 'rejected') {
+    return handleError(error)
+  }

user.password = 'abc'
await user.$save()