open-atmos / camp Goto Github PK

The following line appears to cause errors (inconsistently) with CMake.

This directory doesn't exist in CAMP and therefore isn't copied and will cause an error. This is apparently fine in some cases (such as the current Dockerfile build) but not with newer versions.

Hello @mattldawson ,

I'm merging some changes on CMakeLists from the main branch to my branch, and in the process this warning triggers when compiling with GPU:

nvlink warning : SM Arch ('sm_30') not found in 'CMakeFiles/camplib.dir/src/cuda/camp_gpu_solver.cu.o'

Seems this warning is triggered by setting the SHARED option from "add_library" function, like this:

What is the relevante of SHARED option? It is needed for some test or the fix can be delayed to some point in the future?

Hello @mattldawson,

Reviewing my old notes, I had seen that a difference worth to comment of my GPU branch with the main branch.

In the camp_solver.c file there's a rand() factor in the guesser function like this:

  // Scale incomplete jumps
    if (i_fast >= 0 && h_n > ZERO)
      h_j *= 0.95 + 0.1 * rand() / (double)RAND_MAX;
    h_j = t_n < t_0 + t_j + h_j ? t_n - (t_0 + t_j) : h_j;

In my notes, this random factor is difficulting the profiling, therefore it is disabled (replaced by just h_j *= 0.95 + 0.1) for the GPU branch. Should I keep both versions alive with a compiler option like #ifdef USE_GPU? Or do you have another suggestion?

The HL and SIMPOL uptake rate constant equation needs updated to show the current (Zaveri 2008) equations.

          possibly, although each rate constant type is going to have different sets of data - but maybe I'm not understanding what you're proposing correctly

Originally posted by @mattldawson in #21 (comment)

Sorry, I cannot comment on your comment and also I don't know what are you refering to. This part of code is following the same structure than the CPU code, it shouldn't change so much

Hello @mattldawson ,

I found that the main branch is missing a hotfix discussed a time ago. The change is the following:

The parameters should be -SMALL or TINY to avoid a division by zero which produces null values and sometimes problems on debugging.