Comments (2)
This was resolved in 0b62fe0.
from ontopic-library.
This appears to be based on either an outdated issue or a faulty initial analysis.
If I recall, the initial issue was relevant to cshtml
files, which rely heavily on classes in the ViewFeatures
namespace (as the name suggests), and thus rely on that namespace being in scope. That said, the OnTopic.Attributes
namespace is rarely needed in cshtml
files since it pertains to the entity. And while AttributeDictionary
is used by view models, it is exclusively used as a piece of scaffolding for the ITopicMappingService
, and isn't publicly exposed via the view models, or accessed via the views. As a result, the scenarios where the two AttributeDictionary
classes are used in the same context should be incredibly rare. (It does happen, but mostly when intercepting the view logic, as is done via TopicViewResult
and TopicViewResultExecutor
βwhich is a backend implementation detail, and not a common scenario for implementations).
It is conceivable that something has changed in how the .NET SDK handles global using directives with ASP.NET Core applications, thus resolving conflicts that previously existed (e.g., by exposing global using directives to cshtml
files). That said, this isn't confirmed.
Regardless, this conflict doesn't appear to be an issue, and thus we should revert this work, preferring AttributeDictionary
to AttributeValueDictionary
. This has been done on the OnTopic Library (c0152cc) and the OnTopic Editor (be0b76c).
from ontopic-library.
Related Issues (20)
- Mapping: Ensure cache entries are only pulled once
- `ErrorController`: Bypass for static files HOT 3
- `IsCompatible`: Check `MemberAccessor` against expected `Topic` HOT 1
- Base classes over interfaces?
- Refactor default parameters on interface, virtual methods HOT 1
- Refactor handling of default parameters in method overloads
- Ensure `Topics` table can't have a duplicate key for an attribute HOT 1
- Factor associations into `DeleteOrphanedLastModifiedAttributes` HOT 1
- `TopicController` response caching HOT 7
- Improve reflection performance via e.g., `CreateDelegate()` HOT 7
- Introduce an `ErrorController` to simplify ASP.NET Core error handling HOT 5
- Add support for C# 10 generic attributes HOT 1
- Add support for C# 10 implicit global usings HOT 2
- Add mapping support for `DateOnly`, `TimeOnly`
- ASP.NET Core 6 Host Site, Tests HOT 1
- Upgrade to C# 10, Code Analyzers HOT 1
- Update Development Dependencies HOT 1
- Provide `OnTopicOptions` class for `AddTopicSupport()` HOT 1
- Mapping: Support `IDictionary<>` constructor for manual deserialization HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ontopic-library.