Code Monkey home page Code Monkey logo

api-java-client's People

Contributors

ciaran16 avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

api-java-client's Issues

Possibility of uploading a document with a file stream instead of File object.

Hi team,

Firstly, thanks so much for your work on this SDK! Much appreciated.

I was wondering if it was possible to upload a document to onfido via the Java SDK without first creating a File object. The app I'm working on will receive documents from upstream and I would prefer not to save the file to disk first before sending it onto Onfido, mostly because I already have a ByteArray of the document in memory and also because the nature of the content is PII and I'd rather not have those files stored on the server (albeit temporarily).

Currently the uploadDocument methods require a java.io.File object. Would it be possible to have a version that took an InputStream instead? Or should I be using the REST API directly?

Many thanks,
Chris

Not able to create check

while trying to create check using
api.createCheck(applicantId, check);

getting following error-:

Caused by: java.lang.IllegalStateException: Expected BEGIN_ARRAY but was BEGIN_OBJECT at line 1 column 621 path $.reports[0].documents
at com.google.gson.stream.JsonReader.beginArray(JsonReader.java:350)
at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:79)
at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:60)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:103)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:196)

Not in Maven central

I think it is the case that this library is not published to maven central.

Adding to my pom.xml

<dependency>
    <groupId>com.onfido</groupId>
    <artifactId>onfido-java</artifactId>
    <version>1.5.0</version>
    <scope>compile</scope>
</dependency>

cannot resolve the dependency. https://search.maven.org/search?q=g:com.onfido.api.client also yields no results. I see from https://mvnrepository.com/artifact/com.onfido.api.client/onfido-api-client/2.1.0 this the dependency is in jcenter (but under different group and artefact co-ordinates)

For many server-side (non android users who do not use jcenter as default) the central repo is defined as:

 <repository>
      <snapshots>
        <enabled>false</enabled>
      </snapshots>
      <id>central</id>
      <name>Central Repository</name>
      <url>https://repo.maven.apache.org/maven2</url>
    </repository>

I think it'd either be useful for devs to either:

  1. publish to central too, which appear to be not as hard as it used to be, especially when using https://blog.bintray.com/2014/02/11/bintray-as-pain-free-gateway-to-maven-central/ which suggests it's essentially a setting
  2. Just document in the readme.md of this repository that you'd need to add something like:
<repository>
           <snapshots>
               <enabled>false</enabled>
           </snapshots>
           <id>jcenter</id>
           <name>bintray</name>
           <url>https://jcenter.bintray.com</url>
       </repository>

to your pom.xml.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.