onesky / onesky-ruby Goto Github PK

onesky-ruby (> 1.0.0) ruby depends on
rest-client (> 1.7.2) ruby

where rails 4.2 uses rest-client (1.8.0)

Sent pull-request #5

Hello, I noticed on rubygems.org that the latest version is 1.3.1 but the latest tag/release in this repo is only 1.2.0.

It would be really helpful if you can include the tags for the more recent releases to help us track the source code that we're using 🙏

rest-client 1.8 handle array as months=jan,feb,mar
This is not supported from OneSky API.
Thus, monkey-patched the query string building part.

With rest-client 2.0, it handles array as desired months[]=jan&months[]=feb&months[]=mar, monkey-patch is not needed and should be removed.

Specifically, upload_file is not documented but it doesn't seem like any method is documented.
It should be documented, or at the very least, provide a reference to the HTTP API documentation beside each method.
cc @rubyluk

Hello,
I used your ruby gem to develop a fastlane plugin, to download and upload texts from and to onesky. Unfortunately there is a conflicht with your gems, when using a newer fastlane version than 2.38.1.

fastlane (~> 2.55.0) was resolved to 2.55.0, which depends on
      google-api-client (< 0.14.0, >= 0.13.1) was resolved to 0.13.1, which depends on
        mime-types (~> 3.0)

fastlane-plugin-onesky was resolved to 0.2.1, which depends on
      onesky-ruby was resolved to 1.0.1, which depends on
        rest-client (~> 1.8) was resolved to 1.8.0, which depends on
          mime-types (< 3.0, >= 1.16)

Could you please update your dependency of rest-client to 2.x so that the mime types can be > 3.0.

Thank you.

This is the error I get when I try to connect to your server.

/Users/myHome/.rvm/gems/ruby-2.2.1/gems/rest-client-1.8.0/lib/restclient/request.rb:445:in `rescue in transmit': SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed (RestClient::SSLCertificateNotVerified)
    from /Users/myHome/.rvm/gems/ruby-2.2.1/gems/rest-client-1.8.0/lib/restclient/request.rb:350:in `transmit'
    from /Users/myHome/.rvm/gems/ruby-2.2.1/gems/rest-client-1.8.0/lib/restclient/request.rb:176:in `execute'
    from /Users/myHome/.rvm/gems/ruby-2.2.1/gems/rest-client-1.8.0/lib/restclient/request.rb:41:in `execute'
    from /Users/myHome/.rvm/gems/ruby-2.2.1/gems/rest-client-1.8.0/lib/restclient.rb:65:in `get'
    from /Users/myHome/.rvm/gems/ruby-2.2.1/gems/onesky-ruby-1.0.1/lib/onesky/helpers/request.rb:18:in `get'
    from /Users/myHome/.rvm/gems/ruby-2.2.1/gems/onesky-ruby-1.0.1/lib/onesky/resources/project/base.rb:18:in `list_language'
    from downloadLocals.ruby:20:in `<main>'

Is there any way to ignore peer verification of openssl ?

Is there a way to download translation files in a desired format? (other then the source format of a file)

(this was possible with /string/download endpoint of your Classic API)