onelitefeathernet / antiredstoneclock-remastered Goto Github PK

8.0 1.0 4.0 431 KB

A simple plugin to prevent and detect redstone clocks

Home Page: https://discord.onelitefeather.net

License: GNU Affero General Public License v3.0

Java 100.00%

plotsquared plugin redstone spigotmc minecraft-plugin minecraft-plugin-development papermc antiredstone hacktoberfest worldguard

antiredstoneclock-remastered's People

Contributors

Stargazers

Watchers

Forkers

amitexing czescjestemadam grayservers

antiredstoneclock-remastered's Issues

Adventure implementation breaks on 1.20.2 because of 1.20.4

Expected behaviour:
The commands are executed on 1.20.2 Paper as well because it is backwards supported.

Actual behaviour:
When an user uses the commands on 1.20.2 Paper, the following error is going to happen and it can't execute the commands

Caused by: java.lang.NoSuchMethodError: 'java.util.List net.kyori.adventure.text.TranslatableComponent.arguments()'
	at net.onelitefeather.antiredstoneclockremastered.translations.PluginTranslationRegistry.translate(PluginTranslationRegistry.java:60) ~[AntiRedstoneClock-Remastered-1.0.1-all.jar:?]
	at net.kyori.adventure.translation.GlobalTranslatorImpl.translate(GlobalTranslatorImpl.java:90) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.renderer.TranslatableComponentRenderer$1.renderTranslatable(TranslatableComponentRenderer.java:82) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.renderer.TranslatableComponentRenderer$1.renderTranslatable(TranslatableComponentRenderer.java:74) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.renderer.AbstractComponentRenderer.render(AbstractComponentRenderer.java:50) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.event.HoverEvent$Action$1.render(HoverEvent.java:814) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.event.HoverEvent$Action$1.render(HoverEvent.java:811) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.event.HoverEvent.withRenderedValue(HoverEvent.java:289) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.renderer.TranslatableComponentRenderer.mergeStyle(TranslatableComponentRenderer.java:238) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.renderer.TranslatableComponentRenderer.mergeStyleAndOptionallyDeepRender(TranslatableComponentRenderer.java:222) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.renderer.TranslatableComponentRenderer.renderText(TranslatableComponentRenderer.java:169) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.renderer.AbstractComponentRenderer.render(AbstractComponentRenderer.java:48) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.renderer.TranslatableComponentRenderer.lambda$optionallyRenderChildrenAppendAndBuild$0(TranslatableComponentRenderer.java:228) ~[adventure-api-4.14.0.jar:?]
	at java.util.ArrayList.forEach(ArrayList.java:1511) ~[?:?]
	at java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1092) ~[?:?]
	at net.kyori.adventure.text.renderer.TranslatableComponentRenderer.optionallyRenderChildrenAppendAndBuild(TranslatableComponentRenderer.java:228) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.renderer.TranslatableComponentRenderer.mergeStyleAndOptionallyDeepRender(TranslatableComponentRenderer.java:223) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.renderer.TranslatableComponentRenderer.renderText(TranslatableComponentRenderer.java:169) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.text.renderer.AbstractComponentRenderer.render(AbstractComponentRenderer.java:48) ~[adventure-api-4.14.0.jar:?]
	at net.kyori.adventure.translation.GlobalTranslator.render(GlobalTranslator.java:87) ~[adventure-api-4.14.0.jar:?]
	at io.papermc.paper.adventure.PaperAdventure.translated(PaperAdventure.java:207) ~[paper-1.20.2.jar:git-Paper-228]
	at io.papermc.paper.adventure.PaperAdventure.asJsonString(PaperAdventure.java:192) ~[paper-1.20.2.jar:git-Paper-228]
	at net.minecraft.network.FriendlyByteBuf.writeComponent(FriendlyByteBuf.java:533) ~[?:?]
	at net.minecraft.network.protocol.game.ClientboundSystemChatPacket.write(ClientboundSystemChatPacket.java:46) ~[paper-1.20.2.jar:git-Paper-228]
	at net.minecraft.network.PacketEncoder.encode(PacketEncoder.java:42) ~[paper-1.20.2.jar:git-Paper-228]
	... 77 more

Version: AntiRedstoneClock-Remastered-1.0.1-all

The plugin does not work

The original arc works

2024-03-05.01-24-17.mp4

Add publish data support

Remove the git hash from published version of the hangar and modrinth versions.
To Do that and provide Better Support for us later, use from Chojo the publisdata gradle plugin.

Plugin Failed To Load Without Error

title
https://pastebin.com/vp9bnZyh

https://i.imgur.com/enX6HuM.gif <-- still not break after 7 mins

Add a command for toggling the feature and changing config

title <3

Error using command /arcm display

hello,

im on Paper git-paper-196 1.20.1 R0.1-SNAPSHOT.

when using the command /arcm display a read error displays in chat and console reports error

[21:08:26] [ForkJoinPool.commonPool-worker-2/ERROR]: [AntiRedstoneClock-Remastered] An unhandled exception was thrown during command execution
java.lang.NoSuchMethodError: 'net.kyori.adventure.text.TranslatableComponent net.kyori.adventure.text.TranslatableComponent.arguments(net.kyori.adventure.text.ComponentLike[])'
    at net.onelitefeather.antiredstoneclockremastered.commands.DisplayActiveClocksCommand.displayClocks(DisplayActiveClocksCommand.java:26) ~[AntiRedstoneClock-Remastered-1.0.1-all.jar:?]
    at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732) ~[?:?]
    at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:757) ~[?:?]
    at org.incendo.cloud.annotations.MethodCommandExecutionHandler.executeFuture(MethodCommandExecutionHandler.java:88) ~[AntiRedstoneClock-Remastered-1.0.1-all.jar:?]
    at org.incendo.cloud.execution.ExecutionCoordinatorImpl.lambda$coordinateExecution$4(ExecutionCoordinatorImpl.java:120) ~[AntiRedstoneClock-Remastered-1.0.1-all.jar:?]
    at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1150) ~[?:?]
    at java.util.concurrent.CompletableFuture$Completion.exec(CompletableFuture.java:483) ~[?:?]
    at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?]
    at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?]
    at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?]
    at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?]
    at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?]````

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Update dependency com.intellectualsites.bom:bom-1.16.x to v1.44
Update dependency com.intellectualsites.bom:bom-newest to v1.44
Update plugin xyz.jpenilla.run-paper to v2.3.0
Update gradle/wrapper-validation-action action to v3
Click on this checkbox to rebase all open PRs at once

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

Detected dependencies

github-actions

.github/workflows/build-pr.yml

actions/checkout v4

gradle/wrapper-validation-action v2

actions/setup-java v4

.github/workflows/build.yml

actions/checkout v4

gradle/wrapper-validation-action v2

actions/setup-java v4

actions/upload-artifact v4

.github/workflows/close_invalid_prs.yml

superbrothers/close-pull-request v3

.github/workflows/release-drafter.yml

release-drafter/release-drafter v6

gradle

settings.gradle.kts

io.papermc.paper:paper-api 1.20.4-R0.1-SNAPSHOT

net.kyori:adventure-api 4.16.0

net.kyori:adventure-text-minimessage 4.16.0

net.kyori:adventure-platform-bukkit 4.3.2

org.bstats:bstats-bukkit 3.0.2

org.incendo:cloud-paper 2.0.0-SNAPSHOT

org.incendo:cloud-annotations 2.0.0-SNAPSHOT

org.incendo:cloud-minecraft-extras 2.0.0-SNAPSHOT

de.chojo.publishdata 1.4.0

com.modrinth.minotaur 2.+

io.papermc.hangar-publish-plugin 0.1.2

net.minecrell.plugin-yml.bukkit 0.6.0

xyz.jpenilla.run-paper 2.2.3

com.github.johnrengelman.shadow 8.1.1

build.gradle.kts

net.kyori:adventure-text-feature-pagination 4.0.0-SNAPSHOT

PlotSquaredv4Support/build.gradle.kts

com.github.IntellectualSites.PlotSquared:Core 4.453

com.github.IntellectualSites.PlotSquared:Bukkit 4.453

io.papermc.paper:paper-api 1.20.1-R0.1-SNAPSHOT

PlotSquaredv6Support/build.gradle.kts

com.intellectualsites.bom:bom-1.16.x 1.43

io.papermc.paper:paper-api 1.20.1-R0.1-SNAPSHOT

PlotSquaredv7Support/build.gradle.kts

com.intellectualsites.bom:bom-newest 1.43

io.papermc.paper:paper-api 1.20.1-R0.1-SNAPSHOT

WorldGuardv6Support/build.gradle.kts

com.sk89q.worldguard:worldguard-legacy 6.2

com.sk89q.worldedit:worldedit-bukkit 6.0

io.papermc.paper:paper-api 1.20.1-R0.1-SNAPSHOT

WorldGuardv7Support/build.gradle.kts

com.sk89q.worldguard:worldguard-bukkit 7.0.9

io.papermc.paper:paper-api 1.20.1-R0.1-SNAPSHOT

internal-api/build.gradle.kts

io.papermc.paper:paper-api 1.20.1-R0.1-SNAPSHOT

org.junit:junit-bom 5.10.2

gradle-wrapper

gradle/wrapper/gradle-wrapper.properties

gradle 8.7

Check this box to trigger a request for Renovate to run again on this repository

We need permission bundles in order to sort and bundle the permissions, making it also easier to use permissions on the other hand. For example there can be a permission bundle for administrators having all permissions like arcr.admin and one for "developers" which may only need less perms, for example only reload the setting or disabling the display, like arcr.dev

That is only a suggestion, feel free to change that.

Possible exploit technique needs to be considered

Description

As in https://gitlab.com/Trafalcraft/antiRedstoneClock/-/issues/23 it is mentioned that a "redstone-wire network" can be abused in combination of anti redstone plugin solutions to create lag and possible server crash.

How it is working

At the moment, the logic of ARC-R is similar to this project. Every redstone source that can send and receive redstone signals is considered to be a redstone clock.

Suggestion

Possible pathfinding or search algorithm to minimise object creation, also not dropping everything (that could be abused further) if the redstone clock is too huge. Chunk-wise redstone clock detection (or even with regions like in Folia) was my first thought.

java.lang.NoClassDefFoundError

org.bukkit.plugin.InvalidPluginException: java.lang.NoClassDefFoundError: net/onelitefeather/antiredstoneclockremastered/api/WorldGuardSupport
at org.bukkit.plugin.java.JavaPluginLoader.loadPlugin(JavaPluginLoader.java:131) ~[patched_1.12.2.jar:git-Reaper-"fff830c"]
at org.bukkit.plugin.SimplePluginManager.loadPlugin(SimplePluginManager.java:327) ~[patched_1.12.2.jar:git-Reaper-"fff830c"]
at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:250) ~[patched_1.12.2.jar:git-Reaper-"fff830c"]
at org.bukkit.craftbukkit.v1_12_R1.CraftServer.loadPlugins(CraftServer.java:318) ~[patched_1.12.2.jar:git-Reaper-"fff830c"]
at net.minecraft.server.v1_12_R1.DedicatedServer.init(DedicatedServer.java:223) ~[patched_1.12.2.jar:git-Reaper-"fff830c"]
at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:638) ~[patched_1.12.2.jar:git-Reaper-"fff830c"]
at java.lang.Thread.run(Unknown Source) [?:?]
Caused by: java.lang.NoClassDefFoundError: net/onelitefeather/antiredstoneclockremastered/api/WorldGuardSupport
at java.lang.Class.forName0(Native Method) ~[?:?]
at java.lang.Class.forName(Unknown Source) ~[?:?]
at org.bukkit.plugin.java.PluginClassLoader.init(PluginClassLoader.java:78) ~[patched_1.12.2.jar:git-Reaper-"fff830c"]
at org.bukkit.plugin.java.JavaPluginLoader.loadPlugin(JavaPluginLoader.java:127) ~[patched_1.12.2.jar:git-Reaper-"fff830c"]
... 6 more
Caused by: java.lang.ClassNotFoundException: net.onelitefeather.antiredstoneclockremastered.api.WorldGuardSupport
at java.net.URLClassLoader.findClass(Unknown Source) ~[?:?]
at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:152) ~[patched_1.12.2.jar:git-Reaper-"fff830c"]```