angular-http-interceptors's Issues
Rename jwt interceptor
Rename the jwt interceptor file and class to something that actually describes the purpose of the file. Something like "auth interceptor".
Use camelCase instead of snake_case for variable names
Extract "wrapper" class to "styles.css"
I see the wrapper
class in several places. It would make sense to extract that class to styles.css
so it can be used everywhere.
Change empty success block of the "tap" operator in 401 interceptor to an empty function
Right now the success block has an if statement...just make it an empty arrow function as we are only concerned with the error block.
Update Readme
- Add a "Prerequisites" section
- Add a "Getting Started" section
- Add a screenshot of the app at the top of the Readme
You can leave everything that is currently there at the bottom of the above items.
Use this as a reference (all the way through "Getting Started").
"callback" is not a sufficiently descriptive method name
Name methods according to what they do...something like handleAccessToken
would work here.
Remove unnecessary "then" function
This function does nothing except a console.log
so let's remove it.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.