omgaz / diffler Goto Github PK

Due to the recursive nature of diffler if an array contains objects and strings, for example, when the recursion is called obj1 would be an object, but obj2 would be a string. Therefore key in obj2 would fail.

To resolve this, we'd need to check array types

Write test coverage for TestFactory nested JSON.

e.g. https://github.com/gustf/js-levenshtein/blob/master/bench.js

Allow .init to accept an object.

Would be nice to have some methods to provide intelligent analysis of the diff object.

Benefits

Lower kbs, means faster downloads, less bandwidth, smaller footprint

Considerations

• Source maps

More ops per second.

Depends upon #11

• npm release bundle size down thanks to #30

Automatically fix styling and readability issues in the code and align code base to common best practices.

Implement test coverage for main JS Diff

Not really a bug I suppose but where you have two arrays in an object that are identical but in a different order diffler sees these as totally different arrays.

    const obj1 = {
        myArray: [
            { foo: 'bar' },
            { baz: 'bat' }
        ]
    }

    const obj2 = {
        myArray: [
            { baz: 'bat' },
            { foo: 'bar' }
        ]
    }

    const diff = diffler(obj1, obj2)

    console.log(JSON.stringify(diff))

gives

{"myArray":{"0":{"foo":{"from":"bar","to":null},"baz":{"from":null,"to":"bat"}},"1":{"baz":{"from":"bat","to":null},"foo":{"from":null,"to":"bar"}}}}

so would be nice to have an option to ignore ordering in arrays

but even if you accept that the order does matter I am not sure how 'human readable' this output is? But I am sure this is pretty complex stuff I wouldn't like to try ;-)

This library seems to fill a gap I am searching for this kind of tool to compare changes between json objects.

differ?

see what's on npm

Calculate levenstein distances for each comparison object.

Code hasn't been changed in ~5 years, could do with removing some complexity.

diffler function has a complexity of 19, it has many branches as well as recursion.

Depends upon #11