Code Monkey home page Code Monkey logo

olo-serve-gtm-templates's People

Stargazers

Darius Torres avatar

Watchers

Dan Lash avatar Greg Shackles avatar JoEllen Carter avatar Eric S. Law avatar Jacob M. Roufa avatar Timothy Leverett avatar Brian Kitchener avatar Matt C. Wilson avatar Josh Stern avatar James Cloos avatar Bill Pullen avatar Masters avatar Kyle Pace avatar Bob Williams avatar Jake Levitt avatar Mike Devaney avatar Samah avatar Andrew Sidesinger avatar  avatar  avatar Jon Roberts avatar Justin Anderson avatar Chris Riesgo avatar Jack Mott avatar Smita Patankar avatar Doug Mitchell avatar Vira Shnitsar avatar Vasyl Polevyy avatar Tyler Hackwood avatar Daniel Reyes avatar Nick DiChiaro avatar Gustavo Terraciano avatar Anthony H avatar Martin Gehrke avatar  avatar Maddy Clarke avatar Jeff Scott avatar Alec Papierniak avatar Justin Carbonara avatar Pavlo Hrushetskyi avatar Aalap Shastri avatar Nate Henjes avatar Jon Rossway avatar Taras Shkoropad avatar

olo-serve-gtm-templates's Issues

"add_to_cart" Event Fired When Updating Cart

I have the Olo Serve tag and template implemented as instructed.
image

My GTM trigger is also set up as instructed in the ReadMe.
image

During QA, I performed these steps and received the following results in my data layer:

  • First add 2 of the same item to the cart.

image

  • "add_to_cart" event pushes as expected.
    image

  • Click on the item in the cart to go to the edit screen where I reduce quantity to 1.
    image

  • I click "Update Cart" and the data layer shows an "add_to_cart" event instead of "remove_from_cart".
    image

  • Go back to the edit screen and change the spice level of the dish.
    image

  • Clicking "Update Cart" triggers an "add_to_cart" event instead of "update_item".
    image

  • Go back to the edit screen and change quantity from 1 to 2.
    image

  • Clicking "Update Cart" sends an "add_to_cart" event that says I added 2 more items even though I only added 1.
    image

Is this because both the "Add to Cart" and "Update Cart" buttons both have the same data-test-button and data-serve-element CSS selectors? As you can imagine, it messes up the sales funnel rather severely to have 3 items add to cart, 1 item remove from cart, and 1 item updated to instead report as 6 items added to cart.

Template review feedback

Thanks for submitting a template to the gallery, there were a few issues in your template that needed to be resolved ahead of approving the template for the gallery.

  1. The documentation link [https://github.com/ololabs/olo-serve-gtm-templates/README.md](https://github.com/ololabs/olo-serve-gtm-templates/README.md
    Screenshot 2020-12-17 at 1 19 11 PM
    ) provided in the manifest file is not valid. It shows "Not found" error. Please provide a valid URL.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.