Environment

• Python Version: 3.8
• Library Version: [Versão da biblioteca, se aplicável]

Description of the Issue

When running tests using Python 3.8, a TypeError is encountered in the MerkleTree class, specifically in the human_leaves and human_short_leaves properties. This issue does not occur in Python 3.9 or 3.10, indicating it's likely related to type hinting compatibility with Python 3.8.

Error Message

TypeError: 'type' object is not subscriptable

This error occurs when collecting tests that import and use the MerkleTree class.

Steps to Reproduce

1. Set up a Python 3.8 environment.
2. Run pytest on the codebase.
3. Observe the TypeError in the collection phase of the pytest.

Expected Behavior

The MerkleTree class should function correctly without type errors across different Python versions, especially in supported versions like Python 3.8.

Actual Behavior

A TypeError is raised due to the use of Python 3.9+ style list type hints (e.g., list[str]) which are not compatible with Python 3.8.

Possible Solution

Replace the Python 3.9+ list type hints with the Python 3.8 compatible format using the typing module. For instance, change:

@property
def human_leaves(self) -> list[str]:
    ...

to

from typing import List

@property
def human_leaves(self) -> List[str]:
    ...

and similarly for human_short_leaves.

Describe the bug
The proof is '[961, fc6]', which is not in the tree.

I provided 2 wallet addresses:
wallet = [
'0x5ff...54e',
'0x6fb...942',
]

The code is:
wallet_list = [wallet]
mtree = mtree(wallet_list) # build merkle tree by lib 'merkly'
root = mtree.root # calculate root
leaf = mtree.leafs # calculate leafs
proof = mtree.proof(wallet[0]) # print the first wallet address in the wallet list
print('root', root,
'leaf', leaf,
'proof[0]', proof,
)

the output is :
root :
a3ea60c74884e4d8976733e90e586bc56bf738c18c23208b2c4bab42fcc07d10

leaf:
['96120f2536c0e6873e22a4a4c21d8befd3a60a6a04fc0e840c0afee70b38eb36', 'fc669afbb2103e999115554ddba4fabb9d1ea650308c91c143348ca89cb7c256']

proof: # Why the proof is this? I'm very confused.
[961, fc6]

Describe the bug
When attempting to retrieve the root for an empty MerkleTree, a RecursionError is encountered.

To Reproduce

>>> from merkly.mtree import MerkleTree
>>> mtree = MerkleTree([])
>>> mtree.root

Expected behavior
I understand that the root for an empty tree isn't really defined, but it would be better to either return None or raise a more deliberate Exception rather than entering into an infinite recursion loop.

Desktop (please complete the following information):

• OS: MacOS
• Version 0.8.1

need pass hash function:

h = lambda x, y: hash(x + y)

MerkleTree([], h)

NEED WORK AS BYTES

🏎️ More speed

• The current algorithm is recursive, perhaps an iterative algorithm would be more performant
• A benchmark test is needed to measure this

Just Deploy it!

Is your feature request related to a problem? Please describe.

• add classifiers to improve pypi searches

Describe the solution you'd like

• add a field classifiers = [] in pyproject.toml

Describe alternatives you've considered

• the same as before

• We need a better issue and PR model
• We need modern, more expressive labels
• Update Readme

Describe a new Feature

• A clear and concise description of the new feature
• Some context about WHY you want this new feature

Describe what you expect! (Example)

I want Merkly to work like this:

import merkly

data = []
result = merkly.new_feature(data)

assert result == ["new data very cool"]

Describe a new Feature

Study and implement a verkle tree, just for fun

Describe what you expect! (Example)

from merkly.verk import VerkleTree

Docs

Kuszmaul.pdf

Merkly ❤️ MerkleTreeJs

• Our library does not generate the same merkle root as the library MerkleTreeJs

OBJECTIVE

• Implement an algorithm that is compatible with Merkletreejs
• This new algorithm should be optional

Implementation in JS (MerkleTreeJS)

const { MerkleTree } = require('merkletreejs')
const SHA256 = require('crypto-js/sha256')

const leaves = ['a', 'b', 'c', 'd'].map(SHA256)
const tree = new MerkleTree(leaves, SHA256, {})
const root = tree.getRoot().toString('hex')

console.log("SHA256('a'): ", SHA256('a').toString())
console.log("SHA256('a'): ", SHA256('b').toString())
console.log("SHA256('a'): ", SHA256('c').toString())
console.log("SHA256('a'): ", SHA256('d').toString())
console.log("ROOT: ", root)
 

SHA256('a'):  ca978112ca1bbdcafac231b39a23dc4da786eff8147c4e72b9807785afee48bb
SHA256('a'):  3e23e8160039594a33894f6564e1b1348bbd7a0088d42c4acb73eeaed59c009d
SHA256('a'):  2e7d2c03a9507ae265ecf5b5356885a53393a2029d241394997265a1a25aefc6
SHA256('a'):  18ac3e7343f016890c510e93f935261169d9e3f565436429830faf0934f4f8e4
ROOT:  14ede5e8e97ad9372327728f5099b95604a39593cac3bd38a343ad76205213e7

Implementation in Merkly

from merkly.mtree import MerkleTree
import hashlib


def sha256(data):
    return hashlib.sha256(data.encode()).hexdigest()

leaves = ["a", "b", "c", "d"]
tree = MerkleTree(leaves, sha256, merkletreejs=True)
root = "tree.root()"

print("SHA256('a'): ", sha256('a'))
print("SHA256('b'): ", sha256('b'))
print("SHA256('c'): ", sha256('c'))
print("SHA256('d'): ", sha256('d'))
print("ROOT: ", root)

SHA256('a'):  ca978112ca1bbdcafac231b39a23dc4da786eff8147c4e72b9807785afee48bb
SHA256('a'):  3e23e8160039594a33894f6564e1b1348bbd7a0088d42c4acb73eeaed59c009d
SHA256('a'):  2e7d2c03a9507ae265ecf5b5356885a53393a2029d241394997265a1a25aefc6
SHA256('a'):  18ac3e7343f016890c510e93f935261169d9e3f565436429830faf0934f4f8e4
ROOT:  14ede5e8e97ad9372327728f5099b95604a39593cac3bd38a343ad76205213e7

Compatibility

• Merkle root
• Merkle proof
• Merkle proof verification

Build Merkle Root using Rust FFI

I want Merkly to work like this:

import merkly

mtree = MerkleTree(['a', 'b', 'c', 'd'], turbo=True)

# build merkle root using Rust by FFI
assert mtree.root.hex() == '68203f90e9d07dc5859259d7536e87a6ba9d345f2552b5b9de2999ddce9ce1bf'