olivertappin / scoop Goto Github PK

https://godoc.org/github.com/streadway/amqp#Channel.Publish it states;

Since publishings are asynchronous, any undeliverable message will get returned by the server. Add a listener with Channel.NotifyReturn to handle any undeliverable message when calling publish with either the mandatory or immediate parameters as true.

and...

This can return an error when the channel, connection or socket is closed. The error or lack of an error does not indicate whether the server has received this publishing.

This leads to the potential for dropped messages.

Hello,

There's been an issue in using scoop that has seemingly created an issue in queues that are using messages with content types other than text/plain

looking at the code, the content type is always fixed to text/plain meaning if used on a queue where messages are different to this, it can cause issues on the consuming application.

https://github.com/olivertappin/scoop/blob/master/scoop/scoop.go#L184

I would suggest we need to accept content_type as a parameter, rather than only being hardcoded, this gives the option to choose the content_type at point of use.

I can try open a PR, if this is ok?

In https://godoc.org/github.com/streadway/amqp#Channel.Consume it states;

It's advisable to use separate connections for Channel.Publish and Channel.Consume so not to have TCP pushback on publishing affect the ability to consume messages, so this parameter is here mostly for completeness.

It might be advisable to separate the channels for greater robustness.