okdana / mp3sum Goto Github PK

3.99.5:

pavel@ubuntu-pc:/tmp $ lame3995 -b 320 --noreplaygain 01.\ Good\ Times\ Bad\ Times.flac 
LAME 3.99.5 64bits (http://lame.sf.net)
…                               
Writing LAME Tag...done
pavel@ubuntu-pc:/tmp $ mp3sum 01.\ Good\ Times\ Bad\ Times.mp3 
P 64CC:64CC 96A4:96A4 01. Good Times Bad Times.mp3
1 file(s) checked: 1 pass, 0 unsupported, 0 fail

3.100:

pavel@ubuntu-pc:/tmp $ lame3100 -b 320 --noreplaygain 01.\ Good\ Times\ Bad\ Times.flac 
LAME 3.100 64bits (http://lame.sf.net)
…                               
Writing LAME Tag...done
pavel@ubuntu-pc:/tmp $ mp3sum 01.\ Good\ Times\ Bad\ Times.mp3 
U 0000:A76A 0000:A350 01. Good Times Bad Times.mp3
1 file(s) checked: 0 pass, 1 unsupported, 0 fail

Should be installable via pip

Python 2 is officially dead, i haven't used it for anything myself in a very long time, and a lot of Linux distributions no longer include it by default. Don't see any need to continue supporting it

Sometimes, usually when checking a very large number of files with many worker threads, you can get weird outputs like this:

...
P 1234:1234 5678:5678 foo/bar/file1.mp3
P 1234:1234 5678:5678 foo/bar/file3.mp3

P 1234:1234 5678:5678 foo/bar/file4.mp3
P 1234:1234 5678:5678 
P 1234:1234 5678:5678 foo/bar/file5.mp3
foo/bar/file2.mp3
...

The extraneous new-line and the split-apart result for file2.mp3 are apparently the result of output-buffering issues. I think just flushing after each result should fix it. The logger should support this

this is unusual it seems as all other tools i use to work with mp3s do not require that a file have an extension

sorry if i'm bombarding you with issues :) but the ability to write checksums would be a huge plus i think

my use case specifically is being able to pass a CRC test after trimming silence from the file with Mp3splt, however i'd guess that this feature could be helpful for others for various reasons

in my case i'm writing a bash shell script which wraps several utilities used to perform various operations (convert, trim, fix header errors, integrity checking, etc.) and this would be really helpful

... unless you know of an existing program which can write the CRC without transcoding (i'm not aware of anything)

I mentioned in #1 that my fix for that issue would slow things down a bit, and it does. Since it has to check the file names up front now, it's slower to start actually doing work. We should off-load this to the workers (properly, this time)

from README.md, this didn't work for me on Manjaro (Arch)...

git clone [email protected]:okdana/mp3sum.git

but this did...

git clone https://github.com/okdana/mp3sum