ohmyzsh / ohmyzsh-bot Goto Github PK

As #4 demonstrated, we can get the same results by using a purely Node.js solution, which would enable us to get rid of the Dockerfile and deploy the bot on other hosting solutions with Node.js-only servers. Also, it would be more resilient and less error-prone due to not having to clone the repository everytime.

Some of the things the zsh script does:

• Check mergeability of the PR: can be done by checking the mergeable field of the PR event.
• Check which files are modified: we can use the context.github.pulls.listFiles method.
• Check the contents of the diff (to see if aliases or bindkey changes are made): we can parse the patch field of the listFiles response.

Keeping two copies of the same labels is a pain: we have to change the labels.json file when making a label modification in the main repo. We could move the labels.json file to the main repo and also keep track of the appropriate regexp to apply the label. This could be of the following format:

.github/labels.json:

{
	"Area: plugin": "^plugins/\\S+/",
	"Area: theme": "^themes/\\S+",
	...
}

Then, the triage action would grab this file and try to match the regexps, and if it matched, apply the label based on the key.

https://docs.github.com/es/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners

See ohmyzsh/ohmyzsh#7382 (comment)

Seems like a regression of #1