ohler55 / ojc Goto Github PK

Interesting library! it seems very thorough, thanks for publishing it (documentation is very thorough, too!).

I noticed there are a few leaks detected by AddressSanitizer when executing the unit tests, see attached patch (sorry for the zip, it's what github permits 😞 ). I think it's just due to not freeing the objects generated in the tests (eg some missing calls to ojc_destroy()) but I wasn't sure. The command I used (documented in the patch) is:

CFLAGS="-fsanitize=leak -fsanitize=address -fsanitize=undefined" make test

0001-Support-injecting-CFLAGS-from-env.zip

There are several C libraries for JSON parsing which are relatively or very popular, even here on GitHub (e.g. json-c, cJSON, janson). It would help if you could post a comparison of the foci, strengths and weaknesses of these other libraries vis-a-vis oj. It could be a Wiki page or a README section.

Now, it's true that the best comparison would be some third-party surveying multiple libraries impartially, but - it is also meaningful to read library authors' explanations of why they "rolled their own" rather than using an existing library; and what they see as the main differences.