ohager / hirouter Goto Github PK

Err, I wanted to use HiRouter in one of our projects, but got

events.js:141 throw er; // Unhandled 'error' event ^ SyntaxError: 'import' and 'export' may appear only with 'sourceType: module'

Seems, that I need to babel the guy first. Thought it'd be babel'd by our build chain. Need to solve this. This way it's not usable 🎱

Under certain circumstances the transition does not trigger or stucks. I experience this mostly with Flux. A working solution seems to set the following routingImpl option.

const hiRouterOptions = {
		routingImpl: function(url){ setTimeout( () => this.props.history.push(url), 0 ); }
	};

ReactDOM.render(<HiRouter router={Router} options = {hiRouterOptions} />, document.getElementById('app-container'));

This kind of implementation should be default!

For some reasons the ES6,CJS build creates exports.default=HiRouter (in hirouter.js), which makes imports in React projects not that intuitive as I'd like to have. Instead of export default HiRouter I use an explicit export export {HiRouter}. This way, imports work like this const HiRouter = require('react-hirouter').HiRouter.

Ideally, it should be const HiRouter = require('react-hirouter')

Currently, only URL variables (i.e. path/:id) are parsed. See, how to treat more advanced patterns, like path/(:id), or /**/*.jpg

Yeah, it's not issue but i couldn't find the way to say this :)

In a current project we'd problems with IE11 due to Object.assign and string interpolation. While Object.assign can be resolved with a simple shim, the string interpolation feature is a bit more difficult to resolve. It is used inside the dynamic function creation (createMountPathFunction in createRouteFunction.js).

Instead of creating a route by it's url, an alias can be used also.
Implement this.

Should be nice if IndexRoute can be handled, i.e. creating special goToIndex() function. Mind, that IndexRoute has a related parent Route