ognis1205 / nests Goto Github PK

NES Emulator Written in TypeScript/Reacr

to

NES Emulator Written in TypeScript/React

Thanks for the wonderful typed react NES emulator :)

I'm having trouble installing. I get the error:

``
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @material-ui/[email protected]
npm ERR! Found: @types/[email protected]
npm ERR! node_modules/@types/react
npm ERR! dev @types/react@"^18.0.6" from the root project
npm ERR! peerOptional @types/react@"*" from @material-ui/[email protected]
npm ERR! node_modules/@material-ui/types
npm ERR! @material-ui/types@"5.1.0" from @material-ui/[email protected]
npm ERR! node_modules/@material-ui/core
npm ERR! @material-ui/core@"^4.12.3" from the root project
npm ERR! 1 more (@material-ui/icons)
npm ERR! @material-ui/types@"5.1.0" from @material-ui/[email protected]
npm ERR! node_modules/@material-ui/core/node_modules/@material-ui/styles
npm ERR! @material-ui/styles@"^4.11.4" from @material-ui/[email protected]
npm ERR! node_modules/@material-ui/core
npm ERR! @material-ui/core@"^4.12.3" from the root project
npm ERR! 1 more (@material-ui/icons)
npm ERR! 2 more (@types/react-dom, @types/react-transition-group)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional @types/react@"^16.8.6 || ^17.0.0" from @material-ui/[email protected]
npm ERR! node_modules/@material-ui/core
npm ERR! @material-ui/core@"^4.12.3" from the root project
npm ERR! peer @material-ui/core@"^4.0.0" from @material-ui/[email protected]
npm ERR! node_modules/@material-ui/icons
npm ERR! @material-ui/icons@"^4.11.2" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @types/[email protected]
npm ERR! node_modules/@types/react
npm ERR! peerOptional @types/react@"^16.8.6 || ^17.0.0" from @material-ui/[email protected]
npm ERR! node_modules/@material-ui/core
npm ERR! @material-ui/core@"^4.12.3" from the root project
npm ERR! peer @material-ui/core@"^4.0.0" from @material-ui/[email protected]
npm ERR! node_modules/@material-ui/icons
npm ERR! @material-ui/icons@"^4.11.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/booradley/.npm/_logs/2023-09-20T13_38_03_767Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR! /Users/booradley/.npm/_logs/2023-09-20T13_38_03_767Z-debug-0.log
``

Any idea why?

The meat of this implementation is not in react right, so why does it get top billing? I guess it brings more attention to the project than it might otherwise receive but I think this trend should be resisted. Otherwise good work but seems like surfacing nes.ts and its interactions with the canvas would be more illuminating.

Great work on the emulator implementation, it would be great if there could be 2 player support.