ofri / open-knesset Goto Github PK

for some MKs the geocoding fails. we need to store lat,lon in our db, and use them.

I have some theories (regarding issues I was involved with), that there are lots of committee meetings where only a single MK is present.
Could be cool to be able to ask what are all the meetings that only MK A (or MKs A and/or B) attended, sort MKs according to how many meetings like this they have, break it down to issues, etc.

I need this for something specific, but I'm sure this feature could interest others :)

Another interesting thing is to find meetings where there were only MKs and people from the private sector (i.e. no ngos). This can be done manually by tagging, but maybe there's a way to automate this. This could be useful as part of the analysis of the "lone MK" meetings.

for example, in http://oknesset.org/vote/?vote_type=all&order=controversy&time=30
the next link points to http://oknesset.org/vote/?page=2

Buildout currently assumes SVN is installed. At least on a windows machine without SVN installed, an error is thrown. Need to add SVN as a dependency to buildout.

including:
comments
opinions
agendas
tags
popular name

after logging in, i'm redirected to /user/login/ and the message is אתה כבר מחובר.‏ התנתק?
this is not the 1st message we want to show to our users.

I added 2 tags to a law. After I added the second, the first tag gone.

(I used both Chrome and FireFox)

A lot of times the site displayes lists of MKs or parties with numbers beside them.
I find that I'm sometimes not sure what these nubmers mean.
for example, in the parties tab if I choose משמעת סיעתית, I'm only guessing that this number is the percentage, but i'm not sure percentage of what.

maybe a legend explaining what the numbers mean should be displayed somewhere on the page.

also, I think I would rather see this list
ספר ח"כים • הצבעות לח"כ • משמעת סיעתית • משמעת קואליציה/אופוזיציה
aligned to the right because it's hard to notice when aligned to the left.

because their names are written differently.
example:
יעקב (כצל`ה) כ”ץ
usually written as יעקב כץ

need to make the mk search more robust

if i choose "open link in a new tab", I see the MK page in another page.

works in other browsers

put a hover tooltip on the exclamation mark, to explain its meaning.

(In other browsers it works)

Howdie, I hope this is the right place to request features.

In an online discussion the argument was raised that "Meretz and Haddash sponsored many bills together and blocked many bad legislations too". Well, at the current Oknesset layout, I can only see bills and laws per MK, not per party, and it's impossible to fish out the most fruitful collaborations.

We'd like to see:

1. Aggregated bill/law proposals and passes per party or group of parties.
2. statistics of inter-party bill collaborations, maybe on personal level too (such as "Uri Orbach and Dov Hanin collaborate on laws more than any other two MKs" would be an interesting fact to know.

these are major number-crunching tasks, I know, so they can be run once a month or so, I guess. it doesn't have to be more precise than that...

in the vote: http://oknesset.org/vote/984/ (and many other votes as well)
when i tried to click on "thumb down" (or "thumb up") of a tag i got the page: "דף לא קיים"

Our project has 2 initial_data.json files - one in root and one in src/knesset.
I believe Django loads the initial_data.json from the current directory so we should probably change one of the files to a symbolic link to the other, so you get the same file regardless if you run syncdb from the root or from src/knesset.
Currently the file in src/knesset is newer, but it doesn't load properly for me.

user should get instant verification that his action has been noted and we're working on it.

so people can embed certain view on their sites.

Any query i was trying returned no results.

I tried:
"אורבך"
"מס הכנסה"

and i used: FF, Chrome browesers

age לכתוב גיל במקום
לכתוב אין במקום כלום
בפרטי מקום לידה משום מה אצל כל חבר כנסת מופיע משהו קצת אחר. אצל חלק מופיעה העיר והארץ. אצל חלק רק הארץ ואצל חלק מופיעה הארץ פעמיים

The first Vote has 31 votes
the second has 107...

The activity filter on MK pages like this one uses gender-neutral wording:

הצטרף/ה
פִרסם/ה
נכח/ה
הצביע/ה

The MK gender is known, so why not use gender-specific wording?

This is a bit annoying to implement, since the original code uses English strings that are translated via .po files. Adding gender-specific code would probably require duplicate English strings.

A bit unrelated, the remaining filter option, "הצעה", is not a past-tense verb like the other ones, which is inconsistent, especially since the actual wording in the activity list uses the verb form ("הציע")

MKs that are not members since the beginning of the 18th knesset should not be shown as lazy.

I wanted to login to edit Tag of a law. After I was logged in using Google, I get the main page and not the page i saw before (using FF)

http://oknesset.org/search/?q=%D7%94%D7%A1%D7%93%D7%A8%D7%99%D7%9D

In the same way that user shouldn't select his favorite MK's,

all the other options for votes list should be kept as well, and even after the user get into the details of specific vote, she could easily back to the filtered results.

(The situation today is that she can use "back", but then all the changes she made, like adding a tag, won't be shown)

In the member page, I select which activities to show and hit "Refresh".
The new verbs appear at the url, but in effect only the default verbs are shown (proposed, posted).
Something is overwriting the filters I choose.

אחד הכלים החשובים ביותר שאתר openknesset נותן הוא היכולת להעריך את ביצועי הח"כים. אולם כיום האתר לא ממצה את הפוטנציאל שלו. להלן הצעה אחת לשיפור פשוטה יחסית למימוש.
בדף הח"כ, תחת סטטיסטיקות, במקום להציג :
מספר הצבעות 1081 (ב 30 הימים האחרונים: 117)

עדיף להציג:
מספר הצבעות 1081 (מדורג 1/120)

הסבר:
מספר ההצבעות עצמו אינו אינפורמטיבי מספיק, אלא אם הוא מושווה להישגי הח"כים האחרים. לכן יש להוסיף את דירוג הח"כ מתוך 120 ח"כים (בסוגריים). אותו הדבר לגבי פרמטרים אחרים כגון: משמעת סיעתית, משמעת קואליציונית, שעות שבועיות בממוצע, ישיבות וועדות בחודש, הצעות חוק, הצטרפות להצעות חוק. (השניים האחרונים לא קיימים כיום.)

for many use cases a vote with no summary and no full text is much less interesting. need to indicate which votes has this info in the votes list.

Searching for ח"כ doesn't work, even with exact name matches like ציפי לבני

Django.po:
פיד/הזנה, Doesn't really matter but only one form should be implemented instead of 2 (first strings in the file).

אגנ'דה -> אג׳נדה/אג'נדה (first form of the last two is preferred due to proper usage of Geresh).

Better use gender free terms such as אין בחירה instead of לא נבחר/ה (Line 180).
Since there's no i18n solution for this I guess the best solution would be PHP: set Gender specific terms when needed, I mean that the system saves the gender of the member of Knesset, why not use it when referring to this specific member (Maybe even include plural handling).

Same goes for users handling: posted... (פרסם/פרסמה).

וועדה -> ועדה (Just the proper way of writing it).
BTW ישיבת הוועדה is the correct form so no need to edit.

Line 346: All prior terms are feminine but this one. (נדחתה, חשודה - נמחק).

הכל -> הכול (Spotted in line 459).

Lines 519 to 546: Masculine form, can be solved using PHP.

May not be the best suggestion but maybe using יחדה ונגדה (As opposed to קואליציה ואופוזיציה respectively).

אי-אמון -> אי־אמון (using proper Maqqaf).

Lines 837 to 847: Masculine form again.

856: Should be solved using gender awareness.

882: מציג פעולות is someone (probably a male performing an operation, better use a vague form of פעולות מוצגות).

1287: Masculine form, better use gender agnostic form such as: נכנסת בשם/תחת השם.

1351: להכנס -> להיכנס.

1485: קריאת את (No need to add את after contrast state of קריאה).

1798: where did the colon (:) go?

1834: That masculine form again...

1888: Alternative suggestion - טרם העלית תמונת פרופיל. מומלץ/מוטב להעלות תמונה כעת.

1917: No need for space after the minus (ב- %time%, better use ב־%time%).

Remove: מחיקה/הסרה doesn't really matter but better stick to a single term and use it solely.

1986: להרשם -> להירשם.

2060: הועדות -> הוועדות.

2146: Plural form, better use נא לסמן קטע.

2170: רשיון -> רישיון.

2346: You gotta be kidding me, עמבד?

2734: Better use ב־30 or better: בחודש.

2785: A bit unclear, better rephrase.

תג/תגית Doesn't matter but choose one.

3277: כבר נכנסת instead of all this balagan going on over there.

ססמה is the correct from (rather than סיסמה/סיסמא/ססמא etc.).

3385 to 3399: Singular - עניין, Plural - עניינים (rather than ענינים).

I object to the usage of the word אובייקט, I think עצם or פריט are much more appropriate, and even if we do use the first word it should be properly written as אוביקט (single י there).

General: הוידאו -> הווידאו.

3511: חובה. 30-4 תווים (אותיות, מספרים, רווחים, @/./+/-/_ בלבד).
When listing items the last one should have a trailing ו׳ החיבור. (for example: ירון, צביקה, עפרי וחיים).

General: Alerts was translated as התראות which is correct, but notifications for the exact same term, I suggest using התרעות or better הודעות, referring line 3516, as part of the rephrasing I would suggest התרעה/הודעה בדוא״ל.

3531: Inconsistency between source and translation, I guess fixing the source would solve that unless unnecessary.

Better do some cleanup, the file is overloaded with garbage, although the mo is used there's no need to store such a large amount of unnecessary strings.

DjangoJS.po:
Lots of missing strings and some fixed according to my former suggestions, can I send a commit of my own?

And improvement suggestion:
Better use proper Gershayim (״) instead of Quotation Mark (") - ח״כים instead of ח"כים.
Same goes to Geresh (׳) instead of apostrophe (') - אג׳נדה instead of אג'נדה.
About proper quotation mark there are some options, there's „אלה“ and there's „אלה”, I prefer the first form.

BTW the reason I did this instead of committing is that when a commit is rejected nothing is accepted whilst when agreeing on changes and applying them together leads to a better product and less wasting of time.

Kind regards,
Yaron Shahrabani.

Comments on committee protocol pages have a few usability problems that can be fixed:

1. "X" button is displayed even when I'm not allowed to delete a comment. It should have a "report" button if admins should look at it.
2. Comments are truncated, as in this example -- maybe it's just the hyperlink that's truncated.
3. The action link text is "האירו" with "א", while the "הצגת כל ההערות" checkbox uses "ע"
4. Comments are missing a timestamp, and are not styled like comments elsewhere on the site, for example in bill pages which has a background.
5. There is no visual distinction (besides a newline) between the comment title (with the username) and the body.
6. The comment in the example linked in 2 is position in an odd way in respect to the boxes above and below it. The box also renders over the "האירו" link below it.

When I sign in with a google account, the name presented at the upper left is in a corrupted form.
"sppewqhcjy" is what my name appears as.
Not clear if other information from the Google account is also corrupted.

אני נכנס להצבעה מסויימת תחת "אישור חוקים", ואז הטאב המסומן למעלה קופץ מ"אישור חוקים" ל"הצבעות".

לא קריטי אך טיפה מוזר.

posts show "updated 0 minutes ago" for a long time.

the site is slightly hard to watch under bright lighting conditions. the palette looks real good, but intensity differences don't seem large enough.

Comments on the bill pages appear without hyperlinking the commenting username, and without any punctuation between the username and the date.

For example, see http://oknesset.org/bill/5296/

The comments appear like so:

"פלוני אלמוני‏ 1 חודש, 1 שבוע‏: "

The username should be hyperlinked, and the date should be preceded with the word "before/לפני", and perhaps be inside a span or (html5) time tag.

There's also no line break between the "תגובות" title and the first comment.

In some cases, a single committee protocol "entry" is split into several ones.
See the bottom of http://www.oknesset.org/committee/meeting/1043/#speech-1043-5 for several examples.
"יועצת משפטית" is split into two entries.

סטטיטיקה בדף הח"כ אינה מראה תוצאות נכונות

שחזור
לכו לדף של אורית נוקד1.
http://oknesset.org/member/717/
2. לחצו על נכחו ורענן
3. מתקבלת תוצאה כאילו נכחה בוועדת הכלכלה רק לפני חודש
4. לכו לטאג וועדות לוועדת הכלכלה, ומשם לכו לדיון ב14/07/2010
http://oknesset.org/committee/meeting/2265/
תראו שיש שם שני חכים אחת מהן היא אורית נוקד

clicking the link brings me to a very friendly error message in hebrew.