Geometry bugged when index buffer too large about ogl HOT 2 CLOSED

I figured that this is merely an issue within OGL and not related to the WebGL extensions.
The Primitive generators generate index buffers of type Uint16Array and hence assume that the index array will never need to hold integers above 2^16, which is rather conservative.

The following lines could be enhanced with a ternary to check for the required array type and hence solve the issue relatively elegantly without defaulting to Uint32Array.

In any primitive generator class:
const index = new Uint16Array(numIndices * 6);
We could check whether the maximum possible index value will go over 2^16, and if so generate a Uint32Array.

In the geometry.js file:
attr.type = attr.type || (key === 'index' ? this.gl.UNSIGNED_SHORT : this.gl.FLOAT)
We need to make sure that if the index array is 32bit, this.gl.UNSIGNED_INT is passed in.

from ogl.

Thanks a lot for your detailed explanation. Great addition.

from ogl.