odurc / stimer Goto Github PK
View Code? Open in Web Editor NEWTimer library for microcontrollers / embedded systems
License: MIT License
Timer library for microcontrollers / embedded systems
License: MIT License
Dear Ricardo,
while checking your code, I stumbled into this line:
https://github.com/ricardocrudo/stimer/blob/c9fb881f750aa0e7a2f20e7c7ef0d0adf356bf95/src/stimer.c#L185
I think, the condition should be changed to
if (timer->enabled == 1)
Otherwise, a timer that was frred earlier using stimer_destroy()
and eventually stimer_give()
would not continue
, but would be handled like an enabled timer. -1 == TRUE
Apart from that: Nice code. I think about "stealing" part of it in one of my embedded projects.
Regards,
opt12
Currently library passes stimer_t pointer to the callbacks.
Adding void* arg to the stimer_t struct and passing the arguments via stimer_start would be a good idea.
struct stimer_t {
uint32_t time, counter;
int enabled, overflow;
stimer_mode_t mode;
void* arg;
void (*callback)(void *arg);
};
and changing interface to the
void stimer_start(stimer_t *timer, void* arg);
Doing so, stimer can pass the necessary arguments to the callback function.
Of course, implementation will be changed according to this requirement.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.