odurc / stimer Goto Github PK

Dear Ricardo,
while checking your code, I stumbled into this line:
https://github.com/ricardocrudo/stimer/blob/c9fb881f750aa0e7a2f20e7c7ef0d0adf356bf95/src/stimer.c#L185

I think, the condition should be changed to
if (timer->enabled == 1)
Otherwise, a timer that was frred earlier using stimer_destroy() and eventually stimer_give() would not continue, but would be handled like an enabled timer. -1 == TRUE

Apart from that: Nice code. I think about "stealing" part of it in one of my embedded projects.

Regards,
opt12

Currently library passes stimer_t pointer to the callbacks.

Adding void* arg to the stimer_t struct and passing the arguments via stimer_start would be a good idea.

struct stimer_t {
uint32_t time, counter;
int enabled, overflow;
stimer_mode_t mode;
void* arg;
void (*callback)(void *arg);
};

and changing interface to the

void stimer_start(stimer_t *timer, void* arg);

Doing so, stimer can pass the necessary arguments to the callback function.

Of course, implementation will be changed according to this requirement.