ods / aiochsa Goto Github PK

Snippets for tests:

SELECT toTimeZone(now(), 'UTC')
SELECT toTimeZone(now(), 'EST')
SELECT toTimeZone(now(), 'Europe/Moscow')

This also works, but it could be reconsidered as a bug in Clickhouse and therefore be changed in future releases:

SELECT toStartOfDay(now())

Python 3.9 has native support for timezones (module zoneinfo) and there is backports.zoneinfo.

Using password with "/" (e.g. "6p_/D!h") raise ValueError
Function urlsplit in the dsn_to_params function parse parameter dns (url string) by delim by slash and spoil password

I'd had exception: ValueError: Port could not be cast to integer value as '6p_'

I propose use function connect keyword args for hard password with slash. For example:
aiochsa.connect("clickhouse://localhost:8123/default", user="admin", password="6p_/D!h")

At current implementation using keywords "user" and "password" on create pool is useless, because it will be override at line 58 pool.py
params.update(dsn_to_params(dsn))

I wanna delete all rows from my table, but I'd have exception sqlalchemy.exc.CompileError: WHERE clause is required

My code:
await test_db.execute(electricity_battery.delete())

I cannot type a new connection object, because Pool may not be imported

db_conn: Optional["Pool"] = None

Python and MyPy point to that

Mypy: Name "Pool" is not defined 
Unresolved reference 'Pool' 

Need to add Pool to import at __init__.py

from .pool import connect, create_pool, Pool