odama626 / dawei Goto Github PK

Is this library maintained? The library has no createAtom exported the documentation is incorrect...

store.use currently returns [state, global setter] it would be more intuitive if it returned a scoped setter as well

other state store creation libraries use set first, and since set is more likely to be used and can be used solely it should be first to allow single arg lamdas for ergonomics.

However... set is typically useless for atoms

get should accept strings as well as functions like use does

There is still code pertaining to subscribing to store inside store creation method with createStore(get => get(otherStore)) this functionality is confusing and completely covered by store.subscribe and should be removed

its possible to determine if a state update is a promise, only when it is a promise does it need to be wrapped. otherwise it can be updated immediately so react can batch it on its own. this could be a breaking change though since currently all updates or ordered whether they're async or not. with batching sync updates would be applied first

async function test() {}
undefined
test instanceof Function
true
test() instanceof Promise
true