octomation / makefiles Goto Github PK

because it's already present in generate

because it's not necessary anymore

.PHONY: test-with-coverage
test-with-coverage:
	@go test -cover -covermode atomic -coverprofile c.out -race -timeout $(TIMEOUT) $(PACKAGES) | column -t | sort -r

.PHONY: test-with-coverage-report
test-with-coverage-report: test-with-coverage
	@go tool cover -html c.out

remove test-with-coverage-profile

it tries to update all deps include transitive

need to replace -u to @latest

which only validate compilation

for pre-filling the local cache or to compute the answers for a Go module proxy

now it has a problem with fish and old mac terminal

if gotest present use it, otherwise fallback to go test

AT := @

verbose:
	$(eval AT :=)
	@echo > /dev/null
.PHONY: verbose

candidates:

• rmdir
• deps-update, deps-update-all
• toolset
• hooks
• git-check

from tests

| column -t | sort -r

see https://travis-ci.com/github/kamilsk/breaker/jobs/474205925

$ if [[ $TRAVIS_GO_VERSION == 1.15* ]]; then
  make test-with-coverage
else
  make test
fi

/bin/bash: line 1: -cover: command not found
Makefile:156: recipe for target 'test-with-coverage' failed
make: *** [test-with-coverage] Error 127
The command "if [[ $TRAVIS_GO_VERSION == 1.15* ]]; then
  make test-with-coverage
else
  make test
fi
" exited with 2.

add target git-verify|git-check

• https://github.com/bojand/ghz/blob/master/Makefile
• https://github.com/golangci/golangci-lint/blob/master/Makefile
• https://github.com/goreleaser/goreleaser/blob/master/Makefile

good example

ops: MAIN = ./cmd/control/main.go
ops: BINARY = $(BINPATH)/ops
ops: build
.PHONY: ops

make service client

do the same deps-update, but for tools

• https://github.com/maruel/panicparse
• check how it works with gotest
• make a decision to extend current rules or define new

now tools are not provided by makefile

cause I need docs on top-level

at go-service:

$ make update
...
$ git diff tools/go.mod
-       github.com/golangci/golangci-lint v1.37.1
+       github.com/golangci/golangci-lint v1.38.0

but expected

$ make update
...
$ git diff tools/go.mod
-       github.com/golangci/golangci-lint v1.37.1
-       github.com/grpc-ecosystem/grpc-gateway/v2 v2.2.0
+       github.com/golangci/golangci-lint v1.38.0
+       github.com/grpc-ecosystem/grpc-gateway/v2 v2.3.0
-       google.golang.org/protobuf v1.25.0
+       google.golang.org/protobuf v1.25.1-0.20201208041424-160c7477e0e8

so, why it's happening as above?

https://github.com/octolab/testit/releases/tag/v0.1.0

https://github.com/lyft/protoc-gen-star#documentation-1

• test it first in sandbox
• add a possibility to read shell from env (/usr/bin/env)

remove git hooks

in some cases, I don't want to use tools/etc, but I use a template and it's not ok to adapt it locally.
it will be great to use check before enabling some targets:

ifeq (, wildcard(tools/*))
  target with stub
else
  valid target
endif

candidates:

• tools
• dist without goreleaser/godownloader
• git hooks

• test-integration
• test-integration-quick
• toolset

when I published [email protected] the cache of https://pkg.go.dev/github.com/kamilsk/breaker was a stale long time

• BINPATH, GOBIN move to env
• remove build from module

if dir contains only dirs and they are empty, or the dir is empty, then remove it

GO111MODULE ?= on
GOFLAGS     ?= -mod=vendor
GOPRIVATE   ?= go.octolab.org
GOPROXY     ?= direct
LOCAL       ?= $(MODULE)
MODULE      ?= `GO111MODULE=on go list -m $(GOFLAGS)`
PACKAGES    ?= `GO111MODULE=on go list $(GOFLAGS) ./...
PATHS       ?= $(shell echo $(PACKAGES) | sed -e "s|$(MODULE)/||g" | sed -e "s|$(MODULE)|$(PWD)/*.go|g")
TIMEOUT     ?= 10s

and remove GO111MODULE=on

-include allows to skip if file not found

GOTEST := $(GOTEST) --colored -> GOTEST := $(GOTEST) go --colored

$ make in-go-1.11 test

• support go 1.11 ... 1.14
• test all targets

replace go mod -edit + go mod download by go get -d $$package/...@latest

• SHELL ?= /bin/bash -euo pipefail - pipefail is lost
• @go test -run ^Fake$$ -tags $(GOTAGS) ./... | grep -v 'no tests to run' works unproperly if go test run on single-package module without errors

see https://github.com/lyft/protoc-gen-star#testing

for example, make quick is good to have

if SHELL is not defined then export PATH didn't work properly.

steps to reproduce:

• define export path + shell, exec

print:
    which <file in path>

• remove shell, exec the same target

https://www.gnu.org/software/make/manual/make.html#Variables_002fRecursion
https://stackoverflow.com/questions/8941110/how-i-could-add-dir-to-path-in-makefile