.github's People
Forkers
rarkins wolfy1339 oscard0m isabella232 mtickle bravofinest zhiliangpt dominik-schmid aka2024 jsoref aetotvl6789 top-chief.github's Issues
Rename `renovate.json` to `default.json`
From Renovate logs
Fallback to renovate.json file as a preset is deprecated, please use a default.json file instead.
default.json
is the new default filename for shared presets1. renovate.json
has been deprecated.
Footnotes
Automerging renovate PRs
Please don't use scripts for automerging the renovate PRs.
Whenever a new major version of a dependency is pushed and renovate opens a PR, we should take the time to read the changelog and not blindly merge them because tests are passing.
Because of this, some PRs that contained breaking changes that also affected the dependee package and these were merged as patch releases.
Now, I understand that these PRs could have been marked with a "Request Changes" review and it would have stopped them from being merged, however we shouldn't blindly rely on tests passing to merge these PRs
Renovate still opens updates for GitHub Actions at commit level
Seems like the noise is still there even though we have removed helpers:pinGitHubActionDigests
Example: octokit/auth-unauthenticated.js#161
Should we run a script to move GitHub actions back to a tag? i.e. actions/setup-node@v3
Getting pull request using wrong url?
Discussed in https://github.com/orgs/octokit/discussions/57
Originally posted by TuinboonDev September 9, 2023
Hello, im using this code snippet to get a single pull request:
await context.octokit.rest.pulls.get({ owner, repo, number })
Except it uses this url: https://api.github.com/repos/MYGITHUBNAME/REPO/pulls/?number=9
which gives a 404.
While I think it should be: https://api.github.com/repos/MYGITHUBNAME/REPO/pulls/9
Can anyone help me out?
Renove Bot should not be trying to automerge an opened PR
https://github.com/octokit/rest.js/pull/1988#issuecomment-765050746
Checking the presets and props of renovate.json
is should be trying to autoMerge
. Is this renovate.json
the one being used or there are others extending/overriding this one?
If there is not one I will search for potential opened issues in Renovate Bot repo.
Create 'test.yml' reusable workflow
๐ Description
Create a reusable test.yml workflow to be used across all the repositories of Octokit.js ecosystem.
๐ Goal
- To centralize GitHub Workflows used across repositories in Octokit so we can easily maintain them in a single point
- To reduce the noise Renovatebot produces when a third-party GitHub Action inside our workflows has an update1.
๐ญ Scope
- As a first step, this re-usable workflow will support
octokit/*{.js|.ts}
only. - Runs
npm run lint --if-present
- Runs
npm run build --if-present
(context here)
๐ฎ Future work
- Compose
actions/checkout
andactions/setup-node
and evaluate the execution time (more info here) - Extend this workflow to support the remaining
octokit/*
of the JS Ecosystem (more info here) - To evaluate the type-only test with
tsd
(context here)
๐ Migration Plan
WIP
๐ฌ Discussion points / ๐ซ Blockers
Parametrize node_versions
[Solved โ
]
node_versions
[Solved โ
]
The idea would be to parametrize the node_versions
for strategy.matrix
but apparently, GitHub Action Inputs do not support string[]
as an input type (see here, here and here).
Conclusion ๐งโโ๏ธ
We are using `fromJSON` helper (details [here](https://github.com//pull/13#discussion_r922566626))Custom steps in test.yml
[Solved โ
]
test.yml
[Solved โ
]
Right now, most of our test.yml
used across Octokit.js repositories have the following code:
name: Test
jobs:
test_matrix:
runs-on: ubuntu-latest
strategy:
matrix:
node_version:
- 18
- 20
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node_version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node_version }}
cache: npm
- run: npm ci
- run: npm test
test:
runs-on: ubuntu-latest
needs: test_matrix
steps:
- run: exit 1
if: ${{ needs.test_matrix.result != 'success' }}
- uses: actions/checkout@v3
- run: npm ci
- run: npm run lint
if: ${{ always() }}
But there are some repositories which have extra steps or different steps:
- Example workflow missing
lint
script - Example workflow with extra step:
node scripts/update
- Example workflow with extra steps in
test_matrix
job - etc.
- What approach do we want to follow for custom steps?
- Extra
custom-test
workflows which extend a generictest.yml
? - Add extra logic to
test.yml
to give support to all the use cases?
- Extra
Conclusion ๐งโโ๏ธ
- We want to support all the use cases by adding extra logic (more details [here](https://github.com//pull/13#issuecomment-1186010553)). - As a first step, we will focus onoctokit/*{.js|.ts}
repositories
Footnotes
adjust renovate config to consider lockfile and devDependencies as chore
this morning, i noticed that a lockfile update was treated as a fix
and triggered a new version to be published. i imagine this isnt what you intended, so you might want to consider taking semanticPrefixFixDepsChoreOthers into account in your packageRules
.
i think just starting with
{
"matchPackagePatterns": [
"*"
],
"semanticCommitType": "chore"
}
is likely the detail that you'd want to add.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.