octane / promise Goto Github PK

I think you can replace this line to

var global = this;

because context of AFE is global.

This code doesn't work in the Promise polyfill:

var p1 = Promise.resolve(),
    p2 = Promise.resolve();

p1.then(function () {
    return p2;
}).then(function () {
    //never be called in the polyfill
});

To test compliance with the ES6 promises spec, run the Promises/A+ test suite, since ES6 promises are a superset of it.

Just looking through the code I found several major spec violations.

Nobody should ever use this library as-is.

The polyfill works like the Promise in Chrome:

var p1 = new Promise(function (resolve) {
        resolve();
    }),
    p2 = new Promise(function (resolve) {
        resolve();
    });

p1.then(p2).then(function () {
    //Aurora 31
}, function () {
    //Chrome 36
});

Testing in the polyfill service was showing that this polyfill worked in all our test browsers, but actually that turns out to have been due to a bug in the tests. Could you post browser support numbers on the README of the project?

Here are our results with your polyfill:

IE: 11, 10, 9 pass; 8, 7, 6 fail
FF: 29, 33, 34 native; 20 pass; 3.6 fail
Chrome: 24 native; 26 pass
Safari: 5, 6, 7 pass

For example:

var thenable = {
    then: function (onFulfilled) {
        onFulfilled(5);
    }
};

Promise.resolve(thenable).then(function (value) {
    console.log(value); // 5
});

The test case:

var array = [1, , 2];
Promise.all(array).then(function (values) {
    1 in array  // false
    1 in values // true
});